Fix for collision report to have collided geometry name correctly #1344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ision report can have access to a geometry which has the correct name
…hat collision report can have access to a geometry which has the correct name" This reverts commit bb1c655.
…geometry name even when geometry group is used which is not associated with geometry
kanbouchou
reviewed
Dec 22, 2023
|
#985 fixes this, so i cannot merge this for fear of many conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Geometryhas been stored in CollisionReport since Add geom to collisionreport #990Geometrybut aGeometryInfoBecause of these 3 points, now in production branch,
CollisionReport::__str__()does not show us a collided geometry name when geometry group (i.e. padded geometries) is used.In order to address this issue, I would like to store a geometry name in
FCLGeometryInfoand pass the name to collision report inCheckNarrowPhaseGeomCollision().pipelineid=426516 pipelineid=426623
cc @MiraiHattori @Puttichai