[ci] Fix several release tests #37022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
071220b to
2d4130a
Compare
8 tasks
aslonnie
approved these changes
Jul 1, 2023
| @@ -3676,7 +3676,7 @@ | |||
| script: pytest checkpointing_tests/test_learner_group_checkpointing.py | |||
|
|
|||
| wait_for_nodes: | |||
| num_nodes: 3 | |||
| num_nodes: 2 | |||
There was a problem hiding this comment.
why is this node number change required?
There was a problem hiding this comment.
A previous PR reduces the number of node to 2 #36929, so this needs to update as well
|
https://buildkite.com/ray-project/release-tests-pr/builds/44305 is still failing? |
21bee42 to
3b46add
Compare
Signed-off-by: can <can@anyscale.com>
3b46add to
f054cd7
Compare
|
Some tests still fail but they are the second layer of failures after my fix. I'll leave them for rllib folks to debug them further then. |
avnishn
approved these changes
Jul 3, 2023
arvind-chandra
pushed a commit
to lmco/ray
that referenced
this pull request
Aug 31, 2023
Signed-off-by: can <can@anyscale.com> Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix several release tests. I need to send out instructions on how to write tests with byod soon so people avoid breaking it.
Testing Strategy