[RLlib] Change placement group strategy for learner #36929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: avnishn <avnishnarayan@gmail.com>
Signed-off-by: avnishn <avnishnarayan@gmail.com>
rllib/algorithms/algorithm.py
Outdated
| class AlgorithmBase: | ||
|
|
||
| @staticmethod | ||
| def _get_learner_bundles(cf: AlgorithmConfig): |
There was a problem hiding this comment.
document what it returns?
left is new placement group, right is old placement group, with a learnergroup with 0 workers with 1 gpu
|
Signed-off-by: avnishn <avnishnarayan@gmail.com>
num gpus 1 num workers 1
|
kouroshHakha
approved these changes
Jun 30, 2023
can-anyscale
reviewed
Jul 1, 2023
| max_workers: 2 | ||
| instance_type: g3.8xlarge | ||
| min_workers: 1 | ||
| max_workers: 1 |
There was a problem hiding this comment.
@avnishn since you change the number of worker, you also need to change the number here https://github.com/ray-project/ray/blob/master/release/release_tests.yaml#L3679 to wait for the correct number of node
This broke this test, and some other rllib test in this latest run https://buildkite.com/ray-project/release-tests-branch/builds/1846
Please cherry pick the fix as well since the branch is cut
There was a problem hiding this comment.
I'm putting #37022 to fix
1 task
8 tasks
arvind-chandra
pushed a commit
to lmco/ray
that referenced
this pull request
Aug 31, 2023
Signed-off-by: avnishn <avnishnarayan@gmail.com> Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: avnishn avnishnarayan@gmail.com
Why are these changes needed?
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.