Code De-Duplication & Trait Migrations #1623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add Initial Lifecycle Hooks - Configuring/Configured by @lrljoe in v3 - Initial Lifecycle Hooks - Configuring/Configured rappasoft#1520 Add "HasAllTraits" for Maintainability by @lrljoe in v3 - Splitting Codebase - ConfigurableAreas, CollapsingColumns and TableAttributes rappasoft#1514 Rename row-contents blades for clarity by @lrljoe in V3 Rename row-contents blades rappasoft#1519 Add missing tests for DateFilter and DateTimeFilter by @lrljoe in V3 Adds missing tests for DateTimeFilter and DateFilter rappasoft#1527
Update Changelog
Develop to Master 3.1.2
- Add additional Lifecycle Hook by @lrljoe in rappasoft#1534 - SettingColumns/ColumnsSet - Migrate methods for pre-render out of render by @lrljoe in rappasoft#1534 - Update tests to reflect hooks by @lrljoe in rappasoft#1534 - Update tests to add invalid string tests for dates by @lrljoe in rappasoft#1534 - Remove maps and minimise functions from FrontendAssets by @lrljoe in rappasoft#1534
Develop to Master - Workflows Only
V3 - Develop to Master (3.1.3)
## [v3.1.4] - 2023-12-04 ### New Features - Add capability to hide Column Label by @lrljoe in rappasoft#1512 - Add capability to set a custom script path for the scripts/styles by @lrljoe in rappasoft#1557 - Added rowsRetrieved Lifecycle Hook, expanded documentation for Lifecycle Hooks ### Bug Fixes - Added missing tailwind background colour class for when hovering over the clear button in dark mode by @slakbal in rappasoft#1553 - Fixed extraneous space in config.php by @viliusvsx in in rappasoft#1577 - Changed table default vertical overflow to auto by @dmyers in rappasoft#1573 - Fix footer rendering issue with extra td displayed depending on bulk action statuses ### Tweaks - Create additional Exception Classes (NoColumnsException, NoSearchableColumnsException, NoSortableColumnsException) - Revert previous splitting of JS Files - Add capability to customise Bulk Actions Styling with tests by @lrljoe in rappasoft#1564 - TH Classes - TH Checkbox Classes - TD Classes - TD Checkbox Classes
Pre 3.1.5 release merge
Develop to Master
3.1.7 Develop to Master
* Add Attributes and Callback as Centralised Traits * Fix styling * Initial migration to centralised traits * Fix styling * Add default declaration for view * Fix styling * Migrate Attributes and View to Common Traits * Fix styling * Add HasConfig and HasView traits * Fix styling * Update PHPStan - ignore $view in Views\Column * Fix styling * Moving LocationCallback * Fix styling * Moving More Core Attributes * Fix styling * Migate TitleCallback to own Trait * Fix styling * Move HeaderFooter to Traits * Fix styling * Initial Merge * Fix styling * Update Filters * Fix styling * Add HtmlString Path * Add defaults for additional filters * Fix styling * Fix Filter MultiSelectDropdownFilter STAN Comp * Fix styling * Update MultiSelectFilter * Fix styling * Update selectFilter default configuration options * Fix styling * Migrate Collapsible,Searchable,Sortable to Traits * Fix styling * Tweaks to return types * Fix styling * Remove errant getDefaultValue * Fix full-page-component tests * Fix styling * Update Tests - Include HasFullPageComponent Checks * Fix errant default * Add Model as parameter for getAttributeBag --------- Co-authored-by: lrljoe <lrljoe@users.noreply.github.com>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #1623 +/- ##
=============================================
- Coverage 88.67% 88.13% -0.55%
+ Complexity 1354 1310 -44
=============================================
Files 106 123 +17
Lines 3189 3102 -87
=============================================
- Hits 2828 2734 -94
- Misses 361 368 +7 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MAJOR CHANGE
This change migrates methods, properties, and attributes into centralised traits, to reduce code duplication within the project.
For example, this presents a new "HasAttributes" trait, which is used by both Columns and Filters alike.
The purpose of this is purely to reduce code duplication.
All Submissions:
New Feature Submissions:
Changes to Core Features: