Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V3 - Add Custom Attributes for Bulk Actions #1564

Merged

Conversation

lrljoe
Copy link
Collaborator

@lrljoe lrljoe commented Nov 22, 2023

This PR adds several new methods for customising the look & feel of the Bulk Actions "th" "td" and associated checkboxes, methods documented, but summarised as follows:

  • setBulkActionsThAttributes(array $bulkActionsThAttributes)
    You may pass an array to this method, which allows you to pass Custom Attributes into the table header

  • setBulkActionsThCheckboxAttributes(array $bulkActionsThCheckboxAttributes)
    You may pass an array to this method, which allows you to pass Custom Attributes into the Select All/None checkbox in the Table Header

  • setBulkActionsTdAttributes(array $bulkActionsTdAttributes)
    You may pass an array to this method, which allows you to pass Custom Attributes into the td containing the Bulk Actions Checkbox for a row

  • setBulkActionsTdCheckboxAttributes(array $bulkActionsTdCheckboxAttributes)
    You may pass an array to this method, which allows you to pass Custom Attributes into the Bulk Actions Checkbox for the row

### Currently pending test creation.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests and did you add any new tests needed for your feature?
  2. Did you update all templates (if applicable)?
  3. Did you add the relevant documentation (if applicable)?
  4. Did you test locally to make sure your feature works as intended?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@lrljoe lrljoe added In Progress I've started diagnosing a fix Version 3 Version 3 of Package labels Nov 22, 2023
Copy link

codecov bot commented Nov 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (db0689d) 88.99% compared to head (b8f623a) 89.07%.
Report is 5 commits behind head on develop.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #1564      +/-   ##
=============================================
+ Coverage      88.99%   89.07%   +0.07%     
- Complexity      1268     1276       +8     
=============================================
  Files             96       96              
  Lines           3008     3030      +22     
=============================================
+ Hits            2677     2699      +22     
  Misses           331      331              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lrljoe lrljoe self-assigned this Dec 4, 2023
@lrljoe lrljoe merged commit c12ce7c into rappasoft:develop Dec 4, 2023
@lrljoe lrljoe mentioned this pull request Dec 4, 2023
9 tasks
lrljoe added a commit that referenced this pull request Dec 4, 2023
## [v3.1.4] - 2023-12-04
### New Features
- Add capability to hide Column Label by @lrljoe in #1512
- Add capability to set a custom script path for the scripts/styles by @lrljoe in #1557
- Added rowsRetrieved Lifecycle Hook, expanded documentation for Lifecycle Hooks

### Bug Fixes
- Added missing tailwind background colour class for when hovering over the clear button in dark mode by @slakbal in #1553
- Fixed extraneous space in config.php by @viliusvsx in in #1577
- Changed table default vertical overflow to auto by @dmyers in #1573
- Fix footer rendering issue with extra td displayed depending on bulk action statuses

### Tweaks
- Create additional Exception Classes (NoColumnsException, NoSearchableColumnsException, NoSortableColumnsException)
- Revert previous splitting of JS Files
- Add capability to customise Bulk Actions Styling with tests by @lrljoe in #1564
  - TH Classes
  - TH Checkbox Classes
  - TD Classes
  - TD Checkbox Classes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
In Progress I've started diagnosing a fix Version 3 Version 3 of Package
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant