Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V3 move render methods to trait #1534

Merged
merged 24 commits into from
Nov 3, 2023

Conversation

lrljoe
Copy link
Collaborator

@lrljoe lrljoe commented Nov 3, 2023

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests and did you add any new tests needed for your feature?
  2. Did you update all templates (if applicable)?
  3. Did you add the relevant documentation (if applicable)?
  4. Did you test locally to make sure your feature works as intended?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Copy link

codecov bot commented Nov 3, 2023

Codecov Report

Merging #1534 (ea2fb6a) into develop (e3dfced) will increase coverage by 0.06%.
The diff coverage is 100.00%.

❗ Current head ea2fb6a differs from pull request most recent head 8515a77. Consider uploading reports for the commit 8515a77 to get more accurate results

@@              Coverage Diff              @@
##             develop    #1534      +/-   ##
=============================================
+ Coverage      88.73%   88.80%   +0.06%     
- Complexity      1261     1266       +5     
=============================================
  Files             96       96              
  Lines           2992     3001       +9     
=============================================
+ Hits            2655     2665      +10     
+ Misses           337      336       -1     
Files Coverage Δ
src/DataTableComponent.php 97.05% <100.00%> (-0.09%) ⬇️
src/Traits/WithColumnSelect.php 72.34% <100.00%> (+1.22%) ⬆️
src/Traits/WithFooter.php 100.00% <100.00%> (ø)
src/Traits/WithPagination.php 63.15% <100.00%> (+4.33%) ⬆️
src/Traits/WithReordering.php 91.57% <100.00%> (+0.18%) ⬆️
src/Traits/WithSecondaryHeader.php 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@lrljoe lrljoe marked this pull request as draft November 3, 2023 20:45
@lrljoe lrljoe marked this pull request as ready for review November 3, 2023 21:07
@lrljoe lrljoe merged commit 3a3b42c into rappasoft:develop Nov 3, 2023
This was referenced Nov 3, 2023
lrljoe added a commit that referenced this pull request Nov 3, 2023
- Add additional Lifecycle Hook by @lrljoe in #1534
  - SettingColumns/ColumnsSet
- Migrate methods for pre-render out of render by @lrljoe in #1534
- Update tests to reflect hooks by @lrljoe in #1534
- Update tests to add invalid string tests for dates by @lrljoe in #1534
- Remove maps and minimise functions from FrontendAssets by @lrljoe in #1534
lrljoe added a commit that referenced this pull request Nov 3, 2023
- Add additional Lifecycle Hook by @lrljoe in #1534
  - SettingColumns/ColumnsSet
- Migrate methods for pre-render out of render by @lrljoe in #1534
- Update tests to reflect hooks by @lrljoe in #1534
- Update tests to add invalid string tests for dates by @lrljoe in #1534
- Remove maps and minimise functions from FrontendAssets by @lrljoe in #1534
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant