Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setFilterDefaultValue, Theming Optimization, TypeHint (PHP7.4) Fixes #1191

Merged
merged 36 commits into from
May 10, 2023

Conversation

lrljoe
Copy link
Collaborator

@lrljoe lrljoe commented May 10, 2023

All Submissions:

Changed

  • General

    • Add capability for passing a custom model path to the MakeCommand
    • Add setFilterDefaultValue() on a per-component basis
    • Add getFilterDefaultValue() to each Filter Component (to maintain support for PHP7.4 - variable return types)
    • Moved Setting of Filter Defaults to Traits/Helpers/FilterHelpers - mountFilterHelpers
    • Moved Setting of Theme to Traits/ComponentUtilities - mountComponentUtilities for efficiency
    • Fix for TypeHint to allow continued support of PHP 7.4
  • Filters

  • Documentation

    • Fix - Minor wording tweak to documentation - fix typo #1139
    • Fix - Fix to example in applying-filters
  • Tests

    • Restore PHP 7.4 tests for L8 only (includes minor tweaks)
    • Remove duplicate tests in ComponentHelpersTest
    • Tweak to ReorderingVisualsTest
    • Add TextFilter as a test in FilterHelpersTest
  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests and did you add any new tests needed for your feature?
  2. Did you update all templates (if applicable)?
  3. Did you add the relevant documentation (if applicable)?
  4. Did you test locally to make sure your feature works as intended?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

lrljoe and others added 30 commits May 5, 2023 20:14
* fixed multiSelectDropdownFilter in menus (rappasoft#1160)

deleted a </div> at the end of file

* Extra semicolon in example PHP

---------

Co-authored-by: Chris Thompson <christhompsontldr@gmail.com>
Co-authored-by: Anthony Rappa <rappa819@gmail.com>
Co-authored-by: SamanthaBainCornu <104172362+SamanthaBainCornu@users.noreply.github.com>
@lrljoe lrljoe merged commit f1f7ac7 into rappasoft:develop May 10, 2023
@lrljoe lrljoe added enhancement New feature or request Version 2 Version 2 of Package labels May 12, 2023
@rappasoft rappasoft mentioned this pull request May 18, 2023
@lrljoe lrljoe deleted the develop-213 branch July 15, 2023 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Version 2 Version 2 of Package
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant