Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typo #1139

Closed
wants to merge 1 commit into from
Closed

fix typo #1139

wants to merge 1 commit into from

Conversation

deondazy
Copy link

@deondazy deondazy commented Apr 3, 2023

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests and did you add any new tests needed for your feature?
  2. Did you update all templates (if applicable)?
  3. Did you add the relevant documentation (if applicable)?
  4. Did you test locally to make sure your feature works as intended?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@@ -11,7 +11,7 @@ This package only currently supports Eloquent models. You have two ways of hooki

## Using the model property

If you have a simple table and you know you won't to join any extra tables or make any aliases, you can just use the model property:
If you have a simple table and you know you won't join any extra tables or make any aliases, you can just use the model property:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you would like to create a simple table and know that you won't need to join any extra tables or use any aliases, then you can just use the model property:

@lrljoe
Copy link
Collaborator

lrljoe commented Apr 3, 2023

I've added an alternative take on that doc, let me know what you think!

@lrljoe
Copy link
Collaborator

lrljoe commented Apr 9, 2023

I have used my alternatively proposed text as I feel it gives a clearer explanation of the use. Thank you so much for pointing this out however! Please do raise anything else you spot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants