Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter fix repeated calling #1166

Merged
merged 2 commits into from
Apr 17, 2023

Conversation

lrljoe
Copy link
Collaborator

@lrljoe lrljoe commented Apr 17, 2023

This fix addresses an issue where filters() is called numerous times during the render process. To fix, the following changes are made:

  1. Only calls setFilterDefaults after the component is booted, but before the Builder is set.
  2. Sets a protected variable for Filters, so that it is refreshed after each render, but persists during a single lifecycle
  3. Sets a public count for the filters, which persists for duration (will be reviewed when a "showIf" method is added to the Filters)

This is a performance enhancement only.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests and did you add any new tests needed for your feature?
  2. Did you update all templates (if applicable)?
  3. Did you add the relevant documentation (if applicable)?
  4. Did you test locally to make sure your feature works as intended?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@lrljoe lrljoe merged commit 94f99cd into rappasoft:develop Apr 17, 2023
@AndMe2
Copy link

AndMe2 commented May 12, 2023

This is Great! 23 queries instead of 519. Thank you for this fix!

@lrljoe lrljoe added bug Something isn't working Version 2 Version 2 of Package labels May 12, 2023
@rappasoft rappasoft mentioned this pull request May 18, 2023
@lrljoe lrljoe deleted the FilterFix-RepeatedCalling branch July 15, 2023 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Version 2 Version 2 of Package
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants