-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bugs introduced in geolocalization PR and add labels #39
Conversation
3d8d1af
to
5bdb0ae
Compare
Signed-off-by: Parthvi <parthvi.vala@gmail.com>
Signed-off-by: Parthvi <parthvi.vala@gmail.com>
Signed-off-by: Parthvi <parthvi.vala@gmail.com>
5bdb0ae
to
62fffc1
Compare
var err error | ||
gkeConfig := new(management.GKEClusterConfigSpec) | ||
config.LoadAndUpdateConfig(gke.GKEClusterConfigConfigurationFileKey, gkeConfig, func() { | ||
gkeConfig.ProjectID = project | ||
gkeConfig.KubernetesVersion = &version | ||
gkeConfig.Zone = zone | ||
labels := helper.GetLabels() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it doesn't affect testfilenumber tag, can we move labels variable to suite file ? (applicable for all operators)
Rest changes lgtm.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried doing that earlier but since we are running multiple tests in parallel, I have run into cases where one test is writing to the file and other test is reading from it and there is a conflict because test-2 reads test-1's data. This is particularly seen with AKS, where test-1 takes ResourceGroup of test-2 and then we run into error.
Also, we are using 2 different structs for provisioning and importing tests, so I cannot use the suite file to assign label to the config file since there is no nice way to identify if we are running Provisioning tests or importing.
What does this PR do?
This PR:
owner
andtestfilenumber
labels identify the cluster resource.Which issue(s) this PR fixes (optional, in fixes #(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #10
Checklist:
Special notes for your reviewer: