Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bugs introduced in geolocalization PR and add labels #39

Merged
merged 4 commits into from
Jan 22, 2024

Conversation

valaparthvi
Copy link
Collaborator

@valaparthvi valaparthvi commented Jan 19, 2024

What does this PR do?

This PR:

  1. Fixes bugs introduced in Update all the workflow input with GCP Zone and move to geolocalized instance template #19
  2. Add owner and testfilenumber labels identify the cluster resource.

Which issue(s) this PR fixes (optional, in fixes #(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):

Fixes #10

Checklist:

  • Squashed commits into logical changes
  • Documentation
  • GitHub Actions (if applicable)
    1. EKS-E2E
    2. GKE-E2E
    3. AKS-E2E

Special notes for your reviewer:

@cpinjani cpinjani mentioned this pull request Jan 22, 2024
1 task
@valaparthvi valaparthvi changed the title [WIP] Fix bugs introduced in geolocalization PR and add labels Fix bugs introduced in geolocalization PR and add labels Jan 22, 2024
@valaparthvi valaparthvi force-pushed the revert-geolocalization-2 branch from 3d8d1af to 5bdb0ae Compare January 22, 2024 09:31
Signed-off-by: Parthvi <parthvi.vala@gmail.com>
Signed-off-by: Parthvi <parthvi.vala@gmail.com>
Signed-off-by: Parthvi <parthvi.vala@gmail.com>
var err error
gkeConfig := new(management.GKEClusterConfigSpec)
config.LoadAndUpdateConfig(gke.GKEClusterConfigConfigurationFileKey, gkeConfig, func() {
gkeConfig.ProjectID = project
gkeConfig.KubernetesVersion = &version
gkeConfig.Zone = zone
labels := helper.GetLabels()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it doesn't affect testfilenumber tag, can we move labels variable to suite file ? (applicable for all operators)
Rest changes lgtm.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried doing that earlier but since we are running multiple tests in parallel, I have run into cases where one test is writing to the file and other test is reading from it and there is a conflict because test-2 reads test-1's data. This is particularly seen with AKS, where test-1 takes ResourceGroup of test-2 and then we run into error.

Also, we are using 2 different structs for provisioning and importing tests, so I cannot use the suite file to assign label to the config file since there is no nice way to identify if we are running Provisioning tests or importing.

@valaparthvi valaparthvi requested a review from cpinjani January 22, 2024 13:12
@valaparthvi valaparthvi merged commit d9cf1f4 into main Jan 22, 2024
3 checks passed
@valaparthvi valaparthvi deleted the revert-geolocalization-2 branch January 22, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add labels/annotations to hosted providers cluster to better identify them
2 participants