Update all the workflow input with GCP Zone and move to geolocalized instance template #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f08e92c to
0962476
Compare
220c915 to
4a43a5e
Compare
4a43a5e to
137ee34
Compare
cpinjani
reviewed
Jan 3, 2024
.github/workflows/main.yaml
Outdated
| type: string | ||
| zone: | ||
| description: GCP zone to host the runner | ||
| default: us-west1-b | ||
| default: asia-south2-c |
There was a problem hiding this comment.
Since the instance template is present in that region only, can we avoid providing option to user to select the zone.
https://github.com/rancher/hosted-providers-e2e/actions/runs/7397821063/job/20125653539#step:6:31
137ee34 to
fd68f4a
Compare
fd68f4a to
86606e2
Compare
b40fe8f to
631ddca
Compare
Signed-off-by: Parthvi <parthvi.vala@gmail.com>
Signed-off-by: Parthvi <parthvi.vala@gmail.com>
Signed-off-by: Parthvi <parthvi.vala@gmail.com>
Signed-off-by: Parthvi <parthvi.vala@gmail.com>
Signed-off-by: Parthvi <parthvi.vala@gmail.com>
1ea32f3 to
bcaa18a
Compare
cpinjani
approved these changes
Jan 9, 2024
It seems to have been fixed, but I will wait until https://github.com/rancher/hosted-providers-e2e/actions/runs/7457933467/job/20290982339 finishes. |
This was referenced Jan 16, 2024
This was referenced Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds GCP Zone for running runner in the hosted providers workflow templates so that it is easier to test geolocalized templates and have an option to instantiate the runner in any other region.
Which issue(s) this PR fixes (optional, in fixes #(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Checklist:
1. https://github.com/rancher/hosted-providers-e2e/actions/runs/7395629941/job/201191912352. EKS-E2E3. GKE-E2ESpecial notes for your reviewer: