Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop ros-operator-install and rename populate-node-labels script #180

Merged
merged 2 commits into from
Jul 20, 2022

Conversation

mudler
Copy link
Contributor

@mudler mudler commented Jul 20, 2022

Fixes: #166

Signed-off-by: Ettore Di Giacinto edigiacinto@suse.com

Signed-off-by: Ettore Di Giacinto <edigiacinto@suse.com>
Copy link
Contributor

@kkaempf kkaempf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mudler
Copy link
Contributor Author

mudler commented Jul 20, 2022

mmh. ros-operator-install seems to be used here:

- command: /usr/sbin/ros-operator-install

but as rancherd is no more.. I guess we shouldn't care?

@kkaempf
Copy link
Contributor

kkaempf commented Jul 20, 2022

mmh. ros-operator-install seems to be used here:

- command: /usr/sbin/ros-operator-install

but as rancherd is no more.. I guess we shouldn't care?

Right.
That's probably worth an issue in rancher/elemental.

@Itxaka
Copy link
Contributor

Itxaka commented Jul 20, 2022

Ros-operator-install was dropped as part of #178

@mudler mudler enabled auto-merge (squash) July 20, 2022 16:51
@mudler mudler merged commit cb2b782 into master Jul 20, 2022
@Itxaka
Copy link
Contributor

Itxaka commented Jul 20, 2022

I think this is still being called somewhere in the systemd services and the systemd services are also names wrongly 🙂

@mudler mudler deleted the cleanup branch July 21, 2022 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

There's still ros-operator-install and ros-populate-node-labels in framework/files/usr/sbin
3 participants