Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

There's still ros-operator-install and ros-populate-node-labels in framework/files/usr/sbin #166

Closed
kkaempf opened this issue Jul 14, 2022 · 2 comments · Fixed by #180
Closed

There's still ros-operator-install and ros-populate-node-labels in framework/files/usr/sbin #166

kkaempf opened this issue Jul 14, 2022 · 2 comments · Fixed by #180
Assignees
@mudler

Comments

@kkaempf
Copy link
Contributor

kkaempf commented Jul 14, 2022

Are these still needed ?
@kkaempf kkaempf moved this to 🗳️ To Do in Elemental Jul 14, 2022
@Itxaka
Copy link
Contributor

Itxaka commented Jul 15, 2022

for the e2e testing they are still being used. Either we break the e2e testing by dropping them or we rework the e2e testing to use...elemental-installer? Which means we need to setup a rancher cluster in order to test elemental.

@kkaempf
Copy link
Contributor Author

kkaempf commented Jul 15, 2022

From discussions on the daily

  • drop ros-operator-install
  • rename ros-populate-node-labels to elemental-populate-node-labels

@mudler mudler self-assigned this Jul 20, 2022
@mudler mudler moved this from 🗳️ To Do to 🏃🏼‍♂️ In Progress in Elemental Jul 20, 2022
@mudler mudler mentioned this issue Jul 20, 2022
Merged
Repository owner moved this from 🏃🏼‍♂️ In Progress to ✅ Done in Elemental Jul 20, 2022
@Itxaka Itxaka moved this from ✅ Done to Archive in Elemental Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mudler mudler

Labels
None yet
Projects
Elemental
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Drop ros-operator-install and rename populate-node-labels script rancher/elemental
3 participants
@kkaempf @Itxaka @mudler