Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup ros-operator-install references #186

Closed
mudler opened this issue Jul 21, 2022 · 1 comment
Closed

Cleanup ros-operator-install references #186

mudler opened this issue Jul 21, 2022 · 1 comment
Assignees
@mudler

Comments

@mudler
Copy link
Contributor

mudler commented Jul 21, 2022 •
edited
Loading

Seems there are still references around the ros-operator-install, and not sure if besides those there are around references to elemental-node-label somewhere else besides this repo.

It looks like it was used by rancherd to provision the operator on the control cluster, but as we are using system-agent now, this can be dropped, except for the labelling logic part that should be moved to point to the new binary.

Follow-up of #180
@mudler mudler added this to Elemental Jul 21, 2022
@mudler mudler self-assigned this Jul 21, 2022
@mudler mudler moved this to 🏃🏼‍♂️ In Progress in Elemental Jul 21, 2022
@mudler
Copy link
Contributor Author

mudler commented Jul 25, 2022

Fixed as part of #188

@mudler mudler closed this as completed Jul 25, 2022
Repository owner moved this from 🏃🏼‍♂️ In Progress to ✅ Done in Elemental Jul 25, 2022
@Itxaka Itxaka moved this from ✅ Done to Archive in Elemental Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mudler mudler

Labels
None yet
Projects
Elemental
Archived in project
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mudler