Support getting GraalVM version at native executable build time #43696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Moves core parts of `GraalVM.Version` to `io.quarkus.runtime` to enable us to use the functionality during native executable build time, e.g. from the generated `io.quarkus.runner.Feature` * Infers version from `org.graalvm.vendorversion` property * Avoids breaking existing API * Deprecates methods in the deployment package in favor of those in the runtime package, so that we can eliminate the former in the future.
zakkak
commented
Oct 4, 2024
| * @param exportBefore the version of GraalVM before which the package should be exported (exclusive) | ||
| * @deprecated use {@link #JPMSExportBuildItem(String, String, GraalVM.Version, GraalVM.Version)} instead | ||
| */ | ||
| @Deprecated |
There was a problem hiding this comment.
This might be a bit confusing as it appears like I am adding a Deprecated method, but I actually changed the import and deprecated the method with the old types.
5 tasks
Status for workflow
|
gastaldi
approved these changes
Oct 7, 2024
Yes, that would make sense. Update: I created oracle/graal#9831 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GraalVM.Versiontoio.quarkus.runtimetoenable us to use the functionality during native executable build time,
e.g. from the generated
io.quarkus.runner.Featureorg.graalvm.vendorversionpropertyruntime package, so that we can eliminate the former in the future.
This PR restores the functionality we removed in #36037 to avoid the dependency on the polyglot API. Restoring the functionality allows us to generate
Featurecode conditionally as described in #25975 (comment) which I also need to implement #43533 (reply in thread) in #43448