-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[23.1] GraalVM depends on org.graalvm.home.Version which is polyglot API #35714
Labels
Milestone
Comments
/cc @zakkak |
I'm strongly in faviour of getting rid of the dependency and use a custom parser for the versions (in light of upstream no longer showing anything public about the - internal - version). So getting them to make |
Although unfortunate I agree. We need to go back to doing our own parsing. |
This is also related to #34161 |
zakkak
added a commit
to zakkak/quarkus
that referenced
this issue
Sep 20, 2023
gsmet
pushed a commit
to zakkak/quarkus
that referenced
this issue
Sep 21, 2023
michelle-purcell
pushed a commit
to michelle-purcell/quarkus
that referenced
this issue
Sep 21, 2023
holly-cummins
pushed a commit
to holly-cummins/quarkus
that referenced
this issue
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
GraalVM
class depends on GraalVM'sVersion
class for version parsing. See for example:Since GraalVM Community for JDK 21 (internal version
23.1
), the Version class will be part of thepolyglot.jar
(i.e. theorg.graalvm.polyglot:polyglot
maven artefact after thegraal-sdk
split). The intention for future versions of Quarkus would be to replace the dependency fromgraal-sdk
to the future dependencyorg.graalvm.sdk:nativeimage
only. See oracle/graal#7224There are a couple of avenues to tackle this problem:
org.graalvm.sdk:graal-sdk
dependency gets reduced, it would need to get changed to require both.nativeimage
and thepolyglot
artefact.Version
public API.graal-sdk
dependency forever (has the risk of upstream dropping the empty umbrella maven artefact, though)The text was updated successfully, but these errors were encountered: