Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop relying on org.graalvm.home.Version #36037

Merged
merged 1 commit into from
Sep 21, 2023
Merged

Stop relying on org.graalvm.home.Version #36037

merged 1 commit into from
Sep 21, 2023

Conversation

zakkak
Copy link
Contributor

@zakkak zakkak commented Sep 20, 2023

Closes: #35714

cc @jerboaa

@zakkak zakkak added this to the 3.5 - main milestone Sep 20, 2023
jerboaa
jerboaa approved these changes Sep 20, 2023
View reviewed changes
Copy link
Contributor

@jerboaa jerboaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems OK to me.

@gastaldi gastaldi added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Sep 20, 2023
@gsmet gsmet force-pushed the 2023-09-20-fix-35714 branch from 247001f to c6782ff Compare September 21, 2023 07:19
@quarkus-bot
Copy link

quarkus-bot bot commented Sep 21, 2023

Failing Jobs - Building c6782ff

Status Name Step Failures Logs Raw logs Build scan
✔️ Gradle Tests - JDK 11
✖ Gradle Tests - JDK 11 Windows Build Failures Logs Raw logs
✔️ Maven Tests - JDK 11
✖ Maven Tests - JDK 11 Windows Build Failures Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ Gradle Tests - JDK 11 Windows #

- Failing: integration-tests/gradle

📦 integration-tests/gradle

✖ io.quarkus.gradle.devmode.QuarkusDevDependencyDevModeTest.main line 14 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.test.devmode.util.DevModeClient was not fulfilled within 1 minutes  30 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

⚙️ Maven Tests - JDK 11 Windows #

- Failing: integration-tests/maven

📦 integration-tests/maven

✖ io.quarkus.maven.it.JarRunnerIT.testPlatformPropertiesOverridenInApplicationProperties line 135 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.maven.it.JarRunnerIT that uses io.quarkus.maven.it.verifier.MavenProcessInvocationResult was not fulfilled within 1 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

✖ io.quarkus.maven.it.JarRunnerIT.testPlatformPropertiesOverridenInApplicationProperties line 135 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.maven.it.JarRunnerIT that uses io.quarkus.maven.it.verifier.MavenProcessInvocationResult was not fulfilled within 1 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

@zakkak
Copy link
Contributor Author

zakkak commented Sep 21, 2023

CI failures seem irrelevant.

@zakkak zakkak merged commit f411a65 into quarkusio:main Sep 21, 2023
@zakkak zakkak deleted the 2023-09-20-fix-35714 branch September 21, 2023 12:53
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Sep 21, 2023
@gsmet
Copy link
Member

gsmet commented Sep 21, 2023

@zakkak is "GraalVM 21" what you call "23.1"? If so we probably need the backport label to get this into 3.4.

@zakkak
Copy link
Contributor Author

zakkak commented Sep 21, 2023

@zakkak is "GraalVM 21" what you call "23.1"?

Yes.

If so we probably need the backport label to get this into 3.4.

Only if you plan on bumping the GraalVM version in 3.4. I assumed you would do it in 3.5.
Keep in mind that the version used in 3.4 is Mandrel for JDK 17 (aka 23.0) which is an "LTS" release.

zakkak added a commit to zakkak/quarkus that referenced this pull request Oct 3, 2023
@zakkak
Fix GraalVM.Version#getVersionAsString
2e2c60d 
- Fix joining of version digits
- Don't append "null" suffix

Follow-up to quarkusio#36037
@zakkak zakkak mentioned this pull request Oct 3, 2023
Merged
michelle-purcell pushed a commit to michelle-purcell/quarkus that referenced this pull request Oct 3, 2023
@zakkak @michelle-purcell
Fix GraalVM.Version#getVersionAsString
92ac7d2 
- Fix joining of version digits
- Don't append "null" suffix

Follow-up to quarkusio#36037
holly-cummins pushed a commit to holly-cummins/quarkus that referenced this pull request Feb 8, 2024
@zakkak @holly-cummins
Fix GraalVM.Version#getVersionAsString
214e8f1 
- Fix joining of version digits
- Don't append "null" suffix

Follow-up to quarkusio#36037
@zakkak zakkak mentioned this pull request Oct 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gastaldi gastaldi gastaldi approved these changes

@jerboaa jerboaa jerboaa approved these changes

Assignees
No one assigned
Labels
area/core area/native-image area/testing kind/bugfix
Projects
None yet
Milestone
3.5.0.CR1
Development

Successfully merging this pull request may close these issues.

[23.1] GraalVM depends on org.graalvm.home.Version which is polyglot API
4 participants
@zakkak @gsmet @gastaldi @jerboaa