Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

French translation - FAQ section #6995

Merged
merged 11 commits into from
Nov 3, 2019
Merged

French translation - FAQ section #6995

merged 11 commits into from
Nov 3, 2019

Conversation

Gimly
Copy link
Contributor

@Gimly Gimly commented Oct 9, 2019

Description

This PR adds the translated files for the FAQ section of the documentation in French.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@noroadsleft
Copy link
Member

@Gimly As detailed on #6966 (comment), can you use docs/fr-fr/ as the directory, please? This will also need a rebase at some point. But you can do that when you're done with the actual translating.

Requesting review from @zekth.

@Gimly Gimly force-pushed the french-translation-faq branch from f145997 to c22a035 Compare October 10, 2019 10:38
@Gimly
Copy link
Contributor Author

Gimly commented Oct 10, 2019

OK, I'm done with this part of the translation, this is ready for review.

@noroadsleft I've moved all the files from the fr-FR folder to fr-fr folder, sorry about the issue.

@4sStylZ
Copy link
Contributor

4sStylZ commented Oct 10, 2019

Seem’s that this issue will fixe #7002 because of the file renamed.

@noroadsleft noroadsleft mentioned this pull request Oct 10, 2019
Closed
@Gimly
Copy link
Contributor Author

Gimly commented Oct 11, 2019

@4sStylZ maybe you can help reviewing this pr? Thanks.

@drashna drashna requested a review from a team October 12, 2019 04:41
@4sStylZ
Copy link
Contributor

4sStylZ commented Oct 12, 2019

@4sStylZ maybe you can help reviewing this pr? Thanks.

Yep, it's on my todolist 🐒

@4sStylZ
Copy link
Contributor

4sStylZ commented Oct 12, 2019

I have done the whole review of this but I can't submitting because Github timeout…

If someone have a suggestion please go.

@4sStylZ
Copy link
Contributor

4sStylZ commented Oct 16, 2019

Ok I hate github now and I have submitted all the code of my review on the Gimly github.

I suggest that nobody review this PR for now since he need to correct my suggestionsr or refuse them ;)

@Gimly
Copy link
Contributor Author

Gimly commented Oct 19, 2019

The changes linked to the review from @4sStylZ have been committed to the PR's branch. Maybe another review?

@4sStylZ
Copy link
Contributor

4sStylZ commented Oct 20, 2019

If you can take a look please @zekth

Thank you

@drashna
Copy link
Member

drashna commented Oct 20, 2019

Looks like there is a merge conflict here. If you could resolve that?

@Gimly Gimly force-pushed the french-translation-faq branch from ddaaeaf to ea9ee7d Compare October 20, 2019 20:37
@Gimly
Copy link
Contributor Author

Gimly commented Oct 20, 2019

@drashna rebased on the current master, should be OK now

@Gimly Gimly mentioned this pull request Oct 26, 2019
Merged
13 tasks
Ph0tonic
Ph0tonic suggested changes Oct 26, 2019
View reviewed changes
Copy link
Contributor

@Ph0tonic Ph0tonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small changes.

Ph0tonic
Ph0tonic suggested changes Oct 26, 2019
View reviewed changes
Copy link
Contributor

@Ph0tonic Ph0tonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small modifications.

docs/fr-fr/faq_build.md Outdated Show resolved Hide resolved
docs/fr-fr/faq_build.md Outdated Show resolved Hide resolved
docs/fr-fr/faq_build.md Outdated Show resolved Hide resolved
docs/fr-fr/faq_build.md Outdated Show resolved Hide resolved
docs/fr-fr/faq_debug.md Outdated Show resolved Hide resolved
docs/fr-fr/faq_keymap.md Outdated Show resolved Hide resolved
docs/fr-fr/faq_keymap.md Outdated Show resolved Hide resolved
docs/fr-fr/faq_keymap.md Outdated Show resolved Hide resolved
docs/fr-fr/faq_keymap.md Outdated Show resolved Hide resolved
@Gimly
Copy link
Contributor Author

Gimly commented Oct 27, 2019

@Ph0tonic Thanks a lot for the review, fixed all the comments

@drashna I think it should be good to be merged now

@noroadsleft
Copy link
Member

@Gimly Can you rebase this branch onto a current master again please? Sorry.

noroadsleft mumbles something about too many PRs to keep in his head.

Gimly and others added 4 commits November 3, 2019 11:01
@Gimly
Finished translation of faq_keymap.md
e1d1404
@Gimly
Update faq_build.md
82ef5f0
@4sStylZ @Gimly
Review (#3)
12b24f2 
* Review

* Update docs/fr-fr/faq_keymap.md

* Update docs/fr-fr/faq_debug.md
@Gimly
Fix some PR comments
4782363
@Gimly Gimly force-pushed the french-translation-faq branch from 6015e85 to 4782363 Compare November 3, 2019 10:01
@Gimly
Copy link
Contributor Author

Gimly commented Nov 3, 2019

@noroadsleft I've rebased the branch, should be OK.

That's the Hacktoberfest effect for the number of PRs 😄

@noroadsleft noroadsleft merged commit bed9809 into qmk:master Nov 3, 2019
@noroadsleft
Copy link
Member

Thanks!

@noroadsleft noroadsleft added the hacktoberfest-accepted All the good issues to tackle during Hacktoberfest! label Nov 3, 2019
@Gimly Gimly deleted the french-translation-faq branch November 4, 2019 21:05
@Gimly
Copy link
Contributor Author

Gimly commented Nov 4, 2019

Glad I could help 😄

ripxorip pushed a commit to ripxorip/qmk_firmware that referenced this pull request Dec 3, 2019
@Gimly @4sStylZ @Ph0tonic
French translation - FAQ section (qmk#6995)
ccca6f2 
* Translated faq.md and added all other files (copy from English)

* Translated driver_installation_zadig.md in French

* Translated faq_build.md in French

* Translated faq_debug in French

* Translateed faq_general.md in French

* Translated first part of faq_keymap.md

* Renamed docs/fr-FR folder to docs/fr-fr

* Finished translation of faq_keymap.md

* Update faq_build.md

* Review (qmk#3)

* Review

* Update docs/fr-fr/faq_keymap.md

* Update docs/fr-fr/faq_debug.md

* Fix some PR comments

Co-Authored-By: Noan Mousy <4sstylz@protonmail.ch>
Co-Authored-By: Wermeille Bastien <bastien.wermeille@gmail.com>
patrl pushed a commit to patrl/qmk_firmware that referenced this pull request Dec 29, 2019
@Gimly @4sStylZ
@Ph0tonic @patrl
French translation - FAQ section (qmk#6995)
fa64380 
* Translated faq.md and added all other files (copy from English)

* Translated driver_installation_zadig.md in French

* Translated faq_build.md in French

* Translated faq_debug in French

* Translateed faq_general.md in French

* Translated first part of faq_keymap.md

* Renamed docs/fr-FR folder to docs/fr-fr

* Finished translation of faq_keymap.md

* Update faq_build.md

* Review (qmk#3)

* Review

* Update docs/fr-fr/faq_keymap.md

* Update docs/fr-fr/faq_debug.md

* Fix some PR comments

Co-Authored-By: Noan Mousy <4sstylz@protonmail.ch>
Co-Authored-By: Wermeille Bastien <bastien.wermeille@gmail.com>
HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Feb 21, 2020
@Gimly @4sStylZ
@Ph0tonic @HokieGeek
French translation - FAQ section (qmk#6995)
87847f1 
* Translated faq.md and added all other files (copy from English)

* Translated driver_installation_zadig.md in French

* Translated faq_build.md in French

* Translated faq_debug in French

* Translateed faq_general.md in French

* Translated first part of faq_keymap.md

* Renamed docs/fr-FR folder to docs/fr-fr

* Finished translation of faq_keymap.md

* Update faq_build.md

* Review (qmk#3)

* Review

* Update docs/fr-fr/faq_keymap.md

* Update docs/fr-fr/faq_debug.md

* Fix some PR comments

Co-Authored-By: Noan Mousy <4sstylz@protonmail.ch>
Co-Authored-By: Wermeille Bastien <bastien.wermeille@gmail.com>
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
@Gimly @4sStylZ
@Ph0tonic @noroadsleft
French translation - FAQ section (qmk#6995)
9a8964a 
* Translated faq.md and added all other files (copy from English)

* Translated driver_installation_zadig.md in French

* Translated faq_build.md in French

* Translated faq_debug in French

* Translateed faq_general.md in French

* Translated first part of faq_keymap.md

* Renamed docs/fr-FR folder to docs/fr-fr

* Finished translation of faq_keymap.md

* Update faq_build.md

* Review (qmk#3)

* Review

* Update docs/fr-fr/faq_keymap.md

* Update docs/fr-fr/faq_debug.md

* Fix some PR comments

Co-Authored-By: Noan Mousy <4sstylz@protonmail.ch>
Co-Authored-By: Wermeille Bastien <bastien.wermeille@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noroadsleft noroadsleft noroadsleft approved these changes

@Ph0tonic Ph0tonic Ph0tonic approved these changes

Assignees
No one assigned
Labels
documentation hacktoberfest-accepted All the good issues to tackle during Hacktoberfest! translation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Gimly @noroadsleft @4sStylZ @drashna @Ph0tonic