Review #3
Merged
Review #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gimly
approved these changes
Oct 16, 2019
|
Pour calque, il me semble que c'est bien le cas, c'était un commentaire d'un autre reviewer qui m'avait fait changer ça pour que ce soit consistant avec une autre partie de la doc' en Français. |
|
j'ai corrigé la ligne 182 qui n'était effectivement pas top, je te laisse résoudre le conflit |
Gimly
added a commit
that referenced
this pull request
Feb 9, 2020
* Translated faq.md and added all other files (copy from English) * Translated driver_installation_zadig.md in French * Translated faq_build.md in French * Translated faq_debug in French * Translateed faq_general.md in French * Translated first part of faq_keymap.md * Renamed docs/fr-FR folder to docs/fr-fr * Finished translation of faq_keymap.md * Update faq_build.md * Review (#3) * Review * Update docs/fr-fr/faq_keymap.md * Update docs/fr-fr/faq_debug.md * Fix some PR comments Co-Authored-By: Noan Mousy <4sstylz@protonmail.ch> Co-Authored-By: Wermeille Bastien <bastien.wermeille@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Autres commentaires :
docs/fr-fr/driver_installation_zadig.md l11
Je ne me souviens pas que nous ayons utilisé le terme de calque dans le reste de la doc.
docs/fr-fr/faq_build.md l182
J’ai un peu de mal avec cette phrase.