Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synth Labs Solo Configurator Fixes #18642

Merged
merged 6 commits into from
Oct 8, 2022
Merged

Conversation

noroadsleft
Copy link
Member

Description

  • correct LAYOUT_all key sequence
  • fix layout macro reference
  • add layout data for LAYOUT_left and LAYOUT_right

cc @hongaaronc (keyboard maintainer)

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr merged commit 52a5949 into qmk:master Oct 8, 2022
@noroadsleft noroadsleft deleted the rf/synthlabs_solo branch October 8, 2022 08:02
@hongaaronc
Copy link
Contributor

Thanks for the fixes!

SjB added a commit to SjB/qmk_firmware that referenced this pull request Oct 13, 2022
* upstream/master:
  Remove xealousbrown keyboard (qmk#18658)
  Bugfix waffling60 rev d solder (qmk#18673)
  [Keyboard] Add hardwareabstraction/handwire Board  (qmk#18504)
  Vertex AngleR2 Layout Refactor (qmk#18661)
  [Keyboard][Keymap] Fix random keys being sent on Mac + userspace changes (qmk#15648)
  [Keyboard] New IDOBAO ID61 (a.k.a. Denwir D60) (qmk#17362)
  [Keyboard] Add ANAVI Macro Pad 10 (qmk#18620)
  Fix future naming collisions. (qmk#18645)
  Synth Labs Solo Configurator Fixes (qmk#18642)
  Update CRKBD keymap (qmk#18619)
  Remove all `BACKLIGHT_LEVELS 0` (qmk#18630)
  DD mappings for build.debounce_type and backlight.levels (qmk#18628)
  Add encoder map support for Keychron Q1v1 and Q2 (qmk#18598)
  Studio Kestra Nascent Refactor (qmk#18625)
  [Keyboard] Add supersplit (qmk#18611)
quinnyo pushed a commit to quinnyo/qmk_firmware that referenced this pull request Oct 21, 2022
* info.json: apply friendly formatting

- four-space indent
- line breaks between physical rows

* info.json: fix key sequence

* info.json: fix layout macro reference

The macro `LAYOUT` doesn't exist - this data should reference `LAYOUT_all`.

* info.json: add LAYOUT_left data

* info.json: add LAYOUT_right data

* info.json: correct LAYOUT_right key sequence and positioning
aivalja pushed a commit to aivalja/qmk_firmware that referenced this pull request Nov 7, 2022
* info.json: apply friendly formatting

- four-space indent
- line breaks between physical rows

* info.json: fix key sequence

* info.json: fix layout macro reference

The macro `LAYOUT` doesn't exist - this data should reference `LAYOUT_all`.

* info.json: add LAYOUT_left data

* info.json: add LAYOUT_right data

* info.json: correct LAYOUT_right key sequence and positioning
ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
* info.json: apply friendly formatting

- four-space indent
- line breaks between physical rows

* info.json: fix key sequence

* info.json: fix layout macro reference

The macro `LAYOUT` doesn't exist - this data should reference `LAYOUT_all`.

* info.json: add LAYOUT_left data

* info.json: add LAYOUT_right data

* info.json: correct LAYOUT_right key sequence and positioning
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
* info.json: apply friendly formatting

- four-space indent
- line breaks between physical rows

* info.json: fix key sequence

* info.json: fix layout macro reference

The macro `LAYOUT` doesn't exist - this data should reference `LAYOUT_all`.

* info.json: add LAYOUT_left data

* info.json: add LAYOUT_right data

* info.json: correct LAYOUT_right key sequence and positioning
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants