Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Keyboard] New IDOBAO ID61 (a.k.a. Denwir D60) #17362

Merged
merged 29 commits into from
Oct 10, 2022
Merged

[Keyboard] New IDOBAO ID61 (a.k.a. Denwir D60) #17362

merged 29 commits into from
Oct 10, 2022

Conversation

silvinor
Copy link
Contributor

Description

IDOBAO is proud to release the new IDOBAO ID61 to market - initial GB was via Drop.com (April 2022) (though the Drop offer only showed the 63-key variant, buyers were given the option of the 61-key variant too) with shipping expected around July 2022.

This board, a.k.a. Denwir D60 or D6, comes in two PCB options - this is the 61-key version (commonly called the "poker" layout).

The IDOBAO ID61 is a tailored gasket-mounted 60% keyboard with a unique build to an ultra-compact 61-key layout.

Additional items and notes in this PR

  • Includes the factory default keymap in keymap folder idobao. This adds 4-state RGB toggle key, and Caps-Lock LED indicator that is not part of the default and via keymaps. For this board there is also the option to make the right modifier cluster behave like arrow keys.
  • Default compile include all features of the PCB, but the IDOBAO ID61 cannot leverage underglow. This can be disabled by compile command argument or "#define" as this PCB will be used for future case builds. (the idobao keymap disables this by default)

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

n/a -- (New production keyboard)

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Jun 12, 2022
@drashna drashna requested a review from a team June 12, 2022 02:46
tzarc
tzarc requested changes Jul 2, 2022
View reviewed changes
keyboards/idobao/id61/id61.h Outdated Show resolved Hide resolved
tzarc
tzarc requested changes Jul 2, 2022
View reviewed changes
keyboards/idobao/id61/rules.mk Outdated Show resolved Hide resolved
@silvinor silvinor requested a review from tzarc July 3, 2022 02:28
@silvinor silvinor requested a review from drashna July 26, 2022 08:48
fauxpark
fauxpark requested changes Sep 4, 2022
View reviewed changes
keyboards/idobao/id61/readme.md Outdated Show resolved Hide resolved
keyboards/idobao/id61/post.rules.mk Outdated Show resolved Hide resolved
@silvinor silvinor requested review from sigprof and removed request for drashna, tzarc and noroadsleft September 5, 2022 10:47
@drashna drashna requested a review from a team September 14, 2022 18:15
noroadsleft
noroadsleft requested changes Oct 4, 2022
View reviewed changes
keyboards/idobao/id61/info.json Outdated Show resolved Hide resolved
keyboards/idobao/id61/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/idobao/id61/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/idobao/id61/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/idobao/id61/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/idobao/id61/keymaps/idobao/keymap.c Outdated Show resolved Hide resolved
keyboards/idobao/id61/keymaps/idobao/keymap.c Outdated Show resolved Hide resolved
keyboards/idobao/id61/keymaps/idobao/keymap.c Outdated Show resolved Hide resolved
keyboards/idobao/id61/keymaps/idobao/keymap.c Outdated Show resolved Hide resolved
keyboards/idobao/id61/info.json Show resolved Hide resolved
@silvinor
Copy link
Contributor Author

silvinor commented Oct 5, 2022

@noroadsleft - I have not used a community layout since, when the community layout is used, it does not compile. Specifically when executing the command:

make idobao/id61

(used to compile all instances of the given keymaps)

I get errors in:

  • Making idobao/id61 with keymap brandonschlack-ansi
  • Making idobao/id61 with keymap mechmerlin-ansi
  • Making idobao/id61 with keymap talljoe-ansi

I specifically needed to define an alternative layout so that I could compile without errors.

@silvinor
Copy link
Contributor Author

silvinor commented Oct 9, 2022

ok. i've changed these to the community layout

@noroadsleft noroadsleft merged commit 7aab5e4 into qmk:master Oct 10, 2022
@noroadsleft
Copy link
Member

Thanks!

@silvinor silvinor deleted the vr-id61-new branch October 10, 2022 09:44
@silvinor silvinor mentioned this pull request Oct 10, 2022
Merged
6 tasks
SjB added a commit to SjB/qmk_firmware that referenced this pull request Oct 13, 2022
@SjB
Merge remote-tracking branch 'upstream/master' into sjb/all-keyboard
3e929d4 
* upstream/master:
  Remove xealousbrown keyboard (qmk#18658)
  Bugfix waffling60 rev d solder (qmk#18673)
  [Keyboard] Add hardwareabstraction/handwire Board  (qmk#18504)
  Vertex AngleR2 Layout Refactor (qmk#18661)
  [Keyboard][Keymap] Fix random keys being sent on Mac + userspace changes (qmk#15648)
  [Keyboard] New IDOBAO ID61 (a.k.a. Denwir D60) (qmk#17362)
  [Keyboard] Add ANAVI Macro Pad 10 (qmk#18620)
  Fix future naming collisions. (qmk#18645)
  Synth Labs Solo Configurator Fixes (qmk#18642)
  Update CRKBD keymap (qmk#18619)
  Remove all `BACKLIGHT_LEVELS 0` (qmk#18630)
  DD mappings for build.debounce_type and backlight.levels (qmk#18628)
  Add encoder map support for Keychron Q1v1 and Q2 (qmk#18598)
  Studio Kestra Nascent Refactor (qmk#18625)
  [Keyboard] Add supersplit (qmk#18611)
quinnyo pushed a commit to quinnyo/qmk_firmware that referenced this pull request Oct 21, 2022
@silvinor @quinnyo
[Keyboard] New IDOBAO ID61 (a.k.a. Denwir D60) (qmk#17362)
b4cbff5 
* initial upload

* adjust keymap

* Delete config.h

* Update post.rules.mk

* remapped to correct pins

* add idobao keymap

* disable underglow

* minor fix

* right menu on windows

* imgur

* ID61_process_special_k() function

* KC_APP fix

* Update keymap.c

* pre-pr touchups

* enum layouts

* review changes recommended by tzarc

* refactor special keys to common lib

* rename layout and add info.json labels

* account for 15 possible USER keys

* post drashna review

* Fn Arrow keys added

* post review edits

* use bitmask instead of bool array in specialk.c

* move to community layout
aivalja pushed a commit to aivalja/qmk_firmware that referenced this pull request Nov 7, 2022
@silvinor
[Keyboard] New IDOBAO ID61 (a.k.a. Denwir D60) (qmk#17362)
0a61b54 
* initial upload

* adjust keymap

* Delete config.h

* Update post.rules.mk

* remapped to correct pins

* add idobao keymap

* disable underglow

* minor fix

* right menu on windows

* imgur

* ID61_process_special_k() function

* KC_APP fix

* Update keymap.c

* pre-pr touchups

* enum layouts

* review changes recommended by tzarc

* refactor special keys to common lib

* rename layout and add info.json labels

* account for 15 possible USER keys

* post drashna review

* Fn Arrow keys added

* post review edits

* use bitmask instead of bool array in specialk.c

* move to community layout
ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
@silvinor @ramonimbao
[Keyboard] New IDOBAO ID61 (a.k.a. Denwir D60) (qmk#17362)
a84ca26 
* initial upload

* adjust keymap

* Delete config.h

* Update post.rules.mk

* remapped to correct pins

* add idobao keymap

* disable underglow

* minor fix

* right menu on windows

* imgur

* ID61_process_special_k() function

* KC_APP fix

* Update keymap.c

* pre-pr touchups

* enum layouts

* review changes recommended by tzarc

* refactor special keys to common lib

* rename layout and add info.json labels

* account for 15 possible USER keys

* post drashna review

* Fn Arrow keys added

* post review edits

* use bitmask instead of bool array in specialk.c

* move to community layout
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
@silvinor @nolanseaton
[Keyboard] New IDOBAO ID61 (a.k.a. Denwir D60) (qmk#17362)
af3fb16 
* initial upload

* adjust keymap

* Delete config.h

* Update post.rules.mk

* remapped to correct pins

* add idobao keymap

* disable underglow

* minor fix

* right menu on windows

* imgur

* ID61_process_special_k() function

* KC_APP fix

* Update keymap.c

* pre-pr touchups

* enum layouts

* review changes recommended by tzarc

* refactor special keys to common lib

* rename layout and add info.json labels

* account for 15 possible USER keys

* post drashna review

* Fn Arrow keys added

* post review edits

* use bitmask instead of bool array in specialk.c

* move to community layout
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark requested changes

@tzarc tzarc tzarc requested changes

@noroadsleft noroadsleft noroadsleft approved these changes

@drashna drashna drashna approved these changes

@sigprof sigprof Awaiting requested review from sigprof

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@silvinor @noroadsleft @sigprof @drashna @tzarc @fauxpark