Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove all BACKLIGHT_LEVELS 0 #18630

Merged
merged 2 commits into from
Oct 7, 2022
Merged

Remove all BACKLIGHT_LEVELS 0 #18630

merged 2 commits into from
Oct 7, 2022

Conversation

waffle87
Copy link
Member

@waffle87 waffle87 commented Oct 7, 2022

Description

People copy/pasting useless code...

Types of Changes

  • Keyboard (addition or update)

Issues Fixed or Closed by This PR

tz ci

Generating: .build/obj_contra/src/info_config.h                                                     [ERRORS]
 | 
 | ☒ Invalid API data: contra: backlight.levels: 0 is less than the minimum of 1
 |

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark requested a review from a team October 7, 2022 07:32
@daskygit daskygit merged commit de2c81d into qmk:master Oct 7, 2022
@daskygit
Copy link
Member

daskygit commented Oct 7, 2022

Thanks.

@waffle87 waffle87 deleted the fix/backlight_levels branch October 7, 2022 08:10
SjB added a commit to SjB/qmk_firmware that referenced this pull request Oct 13, 2022
@SjB
Merge remote-tracking branch 'upstream/master' into sjb/all-keyboard
3e929d4 
* upstream/master:
  Remove xealousbrown keyboard (qmk#18658)
  Bugfix waffling60 rev d solder (qmk#18673)
  [Keyboard] Add hardwareabstraction/handwire Board  (qmk#18504)
  Vertex AngleR2 Layout Refactor (qmk#18661)
  [Keyboard][Keymap] Fix random keys being sent on Mac + userspace changes (qmk#15648)
  [Keyboard] New IDOBAO ID61 (a.k.a. Denwir D60) (qmk#17362)
  [Keyboard] Add ANAVI Macro Pad 10 (qmk#18620)
  Fix future naming collisions. (qmk#18645)
  Synth Labs Solo Configurator Fixes (qmk#18642)
  Update CRKBD keymap (qmk#18619)
  Remove all `BACKLIGHT_LEVELS 0` (qmk#18630)
  DD mappings for build.debounce_type and backlight.levels (qmk#18628)
  Add encoder map support for Keychron Q1v1 and Q2 (qmk#18598)
  Studio Kestra Nascent Refactor (qmk#18625)
  [Keyboard] Add supersplit (qmk#18611)
quinnyo pushed a commit to quinnyo/qmk_firmware that referenced this pull request Oct 21, 2022
@waffle87 @quinnyo
Remove all BACKLIGHT_LEVELS 0 (qmk#18630)
bb83129
aivalja pushed a commit to aivalja/qmk_firmware that referenced this pull request Nov 7, 2022
@waffle87
Remove all BACKLIGHT_LEVELS 0 (qmk#18630)
164d2de
ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
@waffle87 @ramonimbao
Remove all BACKLIGHT_LEVELS 0 (qmk#18630)
56cf8ba
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
@waffle87 @nolanseaton
Remove all BACKLIGHT_LEVELS 0 (qmk#18630)
fd7321b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daskygit daskygit daskygit approved these changes

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@waffle87 @daskygit @fauxpark