unify doc preview URLs #3917
unify doc preview URLs #3917
Conversation
|
@pmeier is attempting to deploy a commit to the Meta Open Source Team on Vercel. A member of the Team first needs to authorize it. |
| export const DOCS_URL = "https://docs-preview.pytorch.org"; | ||
| export const PYTHON_DOCS_PATH = "index.html"; | ||
| export const CPP_DOCS_PATH = "cppdocs/index.html"; |
There was a problem hiding this comment.
I've removed the leading and trailing / here, because I found it rather hard to read below when I needed a /.
|
|
In the light of pytorch/pytorch#97433 (review), I've changed the PyTorch PR to not change the path just yet, but additionally upload to the new path we want to go for. As @malfet explains there, this means we can have a grace period where folks will already upload to the new location and if we switch the bot to display the new link this also works on these PRs even though they haven't been rebased. @malfet proposed a grace period of a week. I'm ok with that. Any concerns? |
|
With the new plan, TorchVision also needs a patch: pytorch/vision#7459 |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sister patch for pytorch/test-infra#3917. TL;DR this moves the doc preview scheme to $OWNER/$REPO rather than $REPO that we are currently rolling. Pull Request resolved: #97433 Approved by: https://github.com/seemethere, https://github.com/malfet
|
Both the PyTorch and TorchVision PR have been merged. Meaning, we can move ahead with this PR in a week or so to have a proper grace period. |
|
Grace period is now a little over 2 weeks so we are good to go here. I would start the rollout by merging pytorch/pytorch#99032 since that takes the longest time. Afterwards, these three things need to happen:
|
#3917 was merged so we no longer need to upload to two paths. Note that the new scheme is `{OWNER}/{REPO}/{PR}` and this was dubbed "legacy". Thus, we are actually removing the other one and dropping the legacy label.
Closes #3894. This needs to be merged in unison with a PR on PyTorch core and torchvision. I'll link them here when they are up.