prepare doc preview s3-prefix for future change #7459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/7459
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
Doc preview can now be accessed through
with the former what the bot currently links to and the latter what it will link to in the future. |
osalpekar
approved these changes
Mar 24, 2023
|
Hey @pmeier! You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py |
facebook-github-bot
pushed a commit
that referenced
this pull request
Apr 21, 2023
Reviewed By: vmoens Differential Revision: D44552411 fbshipit-source-id: c292dba3d9c80c381462b55f8eb0f595ec1dc610
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch is correct but somewhat confusing. Right now we are using the
$OWNER/$REPOscheme at the start of the s3-prefix:vision/.github/workflows/docs.yml
Line 68 in 2b25d67
However, the CloudFront setup currently swallows a leading
pytorch/. Thus, our docs are currently served underhttps://docs-preview.pytorch.org/$REPO/$PR/index.html, e.g. https://docs-preview.pytorch.org/vision/7453/index.html.We want to get rid of this configuration in the future. To avoid disruption, this after this PR we will additionally upload to the future location and after a grace period disable the old path.
This means that right now we need to upload with
s3-prefix: pytorch/pytorch/vision/to counteract the CloudFront configuration. After the grace period we can go back to the currentpytorch/vision/since that already uses the$OWNER/$REPOscheme we want. Meaning, after we change the CloudFront configuration, our current setup will upload tohttps://docs-preview.pytorch.org/$OWNER/$REPO/$PR/index.htmlcc @seemethere