remove double doc upload after path unification #4135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pmeier is attempting to deploy a commit to the Meta Open Source Team on Vercel. A member of the Team first needs to authorize it. |
pmeier
commented
May 8, 2023
| @@ -233,6 +222,7 @@ jobs: | |||
| s3-bucket: doc-previews | |||
| if-no-files-found: error | |||
| path: ${{ env.RUNNER_DOCS_DIR }} | |||
| # ${{ env.repository }} is $OWNER/$REPO | |||
There was a problem hiding this comment.
Ok, I was wrong above. Since this contains the owner and repo, the legacy label was correctly attached.
malfet
approved these changes
May 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3917 was merged so we no longer need to upload to two paths. Note that the new scheme is
{OWNER}/{REPO}/{PR}and this was dubbed "legacy". Thus, we are actually removing the other one and dropping the legacy label.