-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Mapbox API to fix map base layers #8887
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #8887 +/- ##
=======================================
Coverage ? 81.85%
=======================================
Files ? 100
Lines ? 5935
Branches ? 0
=======================================
Hits ? 4858
Misses ? 1077
Partials ? 0 |
Code Climate has analyzed commit be5387c and detected 0 issues on this pull request. View more on Code Climate. |
Sagarpreet
approved these changes
Dec 22, 2020
Strangely https://stable.publiclab.org/map is not updating... |
its because it uses LEL: publiclab/leaflet-environmental-layers#491 moving there |
manchere
pushed a commit
to manchere/plots2
that referenced
this pull request
Feb 13, 2021
* Update Mapbox API to fix map base layers * Update tools_places.html.erb * Update nearby.html.erb * Update tools_places.html.erb * Update nearby.html.erb * Update map.html.erb * Update profile.html.erb
lagunasmel
pushed a commit
to lagunasmel/plots2
that referenced
this pull request
Mar 2, 2021
* Update Mapbox API to fix map base layers * Update tools_places.html.erb * Update nearby.html.erb * Update tools_places.html.erb * Update nearby.html.erb * Update map.html.erb * Update profile.html.erb
This was referenced Mar 9, 2021
reginaalyssa
pushed a commit
to reginaalyssa/plots2
that referenced
this pull request
Oct 16, 2021
* Update Mapbox API to fix map base layers * Update tools_places.html.erb * Update nearby.html.erb * Update tools_places.html.erb * Update nearby.html.erb * Update map.html.erb * Update profile.html.erb
billymoroney1
pushed a commit
to billymoroney1/plots2
that referenced
this pull request
Dec 28, 2021
* Update Mapbox API to fix map base layers * Update tools_places.html.erb * Update nearby.html.erb * Update tools_places.html.erb * Update nearby.html.erb * Update map.html.erb * Update profile.html.erb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noting we have more places to do this too:
https://github.com/publiclab/plots2/search?q=https%3A%2F%2Fa.tiles.mapbox.com%2Fv3%2Fjywarren
Following: https://blog.mapbox.com/deprecating-studio-classic-styles-d8892ac38cb4
I wonder if we could also instead use static tiles, not sure if what i selected are among them? OK, confirmed these are static tiles api: https://docs.mapbox.com/api/maps/static-tiles/
@Sagarpreet i wonder if we need to make this update to LEL as well?