Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Mapbox API to fix map base layers #8887

Merged
merged 7 commits into from
Dec 22, 2020
Merged

Update Mapbox API to fix map base layers #8887

merged 7 commits into from
Dec 22, 2020

Conversation

jywarren
Copy link
Member

@jywarren jywarren commented Dec 22, 2020

Noting we have more places to do this too:

https://github.com/publiclab/plots2/search?q=https%3A%2F%2Fa.tiles.mapbox.com%2Fv3%2Fjywarren

Following: https://blog.mapbox.com/deprecating-studio-classic-styles-d8892ac38cb4

I wonder if we could also instead use static tiles, not sure if what i selected are among them? OK, confirmed these are static tiles api: https://docs.mapbox.com/api/maps/static-tiles/

@Sagarpreet i wonder if we need to make this update to LEL as well?

var baseLayer = L.tileLayer('https://api.mapbox.com/styles/v1/jywarren/ckj06ujnc1nmi19nuelh46pr9/tiles/{z}/{x}/{y}?access_token=pk.eyJ1Ijoianl3YXJyZW4iLCJhIjoiVzVZcGg3NCJ9.BJ6ArUPuTs1JT9Ssu3K8ig', {
        tileSize: 512,
        zoomOffset: -1,
        attribution: '© <a href="https://apps.mapbox.com/feedback/">Mapbox</a> © <a href="http://www.openstreetmap.org/copyright">OpenStreetMap</a>'
    }).addTo(map);

@gitpod-io
Copy link

gitpod-io bot commented Dec 22, 2020

@jywarren jywarren requested a review from a team as a code owner December 22, 2020 16:35
@codecov
Copy link

codecov bot commented Dec 22, 2020

Codecov Report

❗ No coverage uploaded for pull request base (main@6505f53). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #8887   +/-   ##
=======================================
  Coverage        ?   81.85%           
=======================================
  Files           ?      100           
  Lines           ?     5935           
  Branches        ?        0           
=======================================
  Hits            ?     4858           
  Misses          ?     1077           
  Partials        ?        0           

@codeclimate
Copy link

codeclimate bot commented Dec 22, 2020

Code Climate has analyzed commit be5387c and detected 0 issues on this pull request.

View more on Code Climate.

@jywarren
Copy link
Member Author

Strangely https://stable.publiclab.org/map is not updating...

@jywarren
Copy link
Member Author

its because it uses LEL: publiclab/leaflet-environmental-layers#491 moving there

manchere pushed a commit to manchere/plots2 that referenced this pull request Feb 13, 2021
* Update Mapbox API to fix map base layers

* Update tools_places.html.erb

* Update nearby.html.erb

* Update tools_places.html.erb

* Update nearby.html.erb

* Update map.html.erb

* Update profile.html.erb
lagunasmel pushed a commit to lagunasmel/plots2 that referenced this pull request Mar 2, 2021
* Update Mapbox API to fix map base layers

* Update tools_places.html.erb

* Update nearby.html.erb

* Update tools_places.html.erb

* Update nearby.html.erb

* Update map.html.erb

* Update profile.html.erb
reginaalyssa pushed a commit to reginaalyssa/plots2 that referenced this pull request Oct 16, 2021
* Update Mapbox API to fix map base layers

* Update tools_places.html.erb

* Update nearby.html.erb

* Update tools_places.html.erb

* Update nearby.html.erb

* Update map.html.erb

* Update profile.html.erb
billymoroney1 pushed a commit to billymoroney1/plots2 that referenced this pull request Dec 28, 2021
* Update Mapbox API to fix map base layers

* Update tools_places.html.erb

* Update nearby.html.erb

* Update tools_places.html.erb

* Update nearby.html.erb

* Update map.html.erb

* Update profile.html.erb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants