Location modal not working on some pages

[jywarren]

Let's deal with this on Monday! 😅

On https://publiclab.org/wiki/unearthing-pvd the Add a location button doesn't seem to work, so I wonder if it's interacting somehow with some of our other mapping code?

I see this error, though, which could be involved:

Uncaught TypeError: element.find(...).tooltip is not a function
    at postProcessContent (xml.js:30)
    at setupWiki (xml.js:30)
    at unearthing-pvd:2108
    at unearthing-pvd:2110

[jywarren]

Hi @nstjean just checking in about this as well, i'd super appreciate some help on this if you have a moment. I noticed this seems to be the case on both the wiki page above, and also on my dashboard. I can open a separate issue for that; it seems also odd because I already have a location on my profile - let's check if there is conditional logic on that template and we'll break it out as a separate issue!

[jywarren]

Thanks!

[nstjean]

Hmmm. I'll take a look. There were two FTOs posted regarding the button, I'll check to make sure both were merged!

[jywarren]

Ah, ok, thanks!

[nstjean]

Ahh here it is. A PR was never submitted for this! #7266 . This is only for the Dashboard, though. It should be working on Wiki pages. I'll keep looking.

[nstjean]

It looks like that console error is stemming from this code here:

plots2/app/views/like/_like.html.erb

Lines 157 to 209 in aa3b864

	$('[rel="tooltip"]').on('click', function () {
	$(this).tooltip('hide')
	})
	function print_three_column() {
	$('body').css('column-count', 3)
	.css('column-gap', '50px');
	$('.popover').popover('hide');
	window.print();
	$('body').css('column-count', 1)
	.css('column-gap', 0);
	}
	// Event listner on CLICK on links
	$(document).on("click", "#print-command-3-col",print_three_column);
	$(document).on("click", "#print-command-no-links",print_linkless);
	jQuery(document).ready(function() {
	// 304 cached response yields no data to insert, which is not useful
	jQuery.ajaxSetup({
	cache: false
	});
	// opens modal to login before you can like;
	$("#open-login-like").click(function() {
	$("input[name='hash_params']").val($(this).attr("data-hashparams"));
	});
	// triggers liking and unliking
	<% if current_user %>
	$('#like-button-<%= node.id %>').on('click', debounce(<% if node.liked_by(current_user.uid) %>clickliked<% else %>clicknotliked<% end %>, 200, true));
	// leaving below uncommented for now - possibility useful for implement comment like functionality?
	// if(window.location.href.includes("#like")) {
	// $('#like-button-<%= node.id %>').click();
	// }
	<% end %>
	});
	$('body').on('click', '.nestedPopover', function() {
	$(this).popover({
	container: 'body',
	trigger: 'focus click'
	});
	$(this).popover('show');
	$(this).removeClass("nestedPopover");
	});
	$('body').on('click', function (e) { // If there's a click event in the body
	$('[rel=popover]').each(function () { // For each popover
	/*
	* The popover will only `hide` if all the conditions below are satisfied :
	* 1. The target triggering the `click` event is not `this`
	* 2. `this` doesn't have a child triggering the `click` event
	* 3. Any element with `.popover` class doesn't have a child triggering the `click` event
	*/
	if (!$(this).is(e.target) && $(this).has(e.target).length === 0 && $('.popover').has(e.target).length === 0) {
	$(this).popover('hide');
	}
	});
	});

It's happening if you click anywhere on the page, not just the button.

[nstjean]

It does look like that error is interfering though. Here is the same issue:
https://stable.publiclab.org/wiki/inline-maps
Possibly it is the inline maps triggering an error there somehow.

[nstjean]

I think this is related: #7355

[jywarren]

I'm now seeing this on /unearthing-pvd:

Access to XMLHttpRequest at 'https://iaspub.epa.gov/enviro/efservice/tri_facility/pref_latitude/BEGINNING/41/PREF_LONGITUDE/BEGINNING/71/rows/0:300/JSON?_=1615315565558' from origin 'https://publiclab.org' has been blocked by CORS policy: No 'Access-Control-Allow-Origin' header is present on the requested resource.

I believe that's actually a 404 error not CORS: the URL directly gives: The requested URL /enviro/efservice/tri_facility/pref_latitude/BEGINNING/41/PREF_LONGITUDE/BEGINNING/71/rows/0:300/JSON was not found.

I'll open an issue based on #8887 for the tile error i'm seeing and let's circle back here.

[jywarren]

Here's a page to test on: https://publiclab.org/wiki/gsoc

I am seeing that clicking the button a 2nd time causes a map initialization error. But let's resolve related issues first then circle back:

publiclab/leaflet-environmental-layers#514 - TRI error

publiclab/leaflet-blurred-location#259 - MapBox API change

[jywarren]

Working now!