Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update base layer tiles due to MapBox deprecation #491

Closed
jywarren opened this issue Dec 23, 2020 · 8 comments
Closed

Update base layer tiles due to MapBox deprecation #491

jywarren opened this issue Dec 23, 2020 · 8 comments

Comments

@jywarren
Copy link
Member

Just like in publiclab/plots2#8887 -- cc @Sagarpreet ❤️
@jywarren
Copy link
Member Author

There are a lot! https://github.com/publiclab/leaflet-environmental-layers/search?q=mapbox

@jywarren
Copy link
Member Author

Following: https://blog.mapbox.com/deprecating-studio-classic-styles-d8892ac38cb4

var baseLayer = L.tileLayer('https://api.mapbox.com/styles/v1/jywarren/ckj06ujnc1nmi19nuelh46pr9/tiles/{z}/{x}/{y}?access_token=pk.eyJ1Ijoianl3YXJyZW4iLCJhIjoiVzVZcGg3NCJ9.BJ6ArUPuTs1JT9Ssu3K8ig', {
        tileSize: 512,
        zoomOffset: -1,
        attribution: '© <a href="https://apps.mapbox.com/feedback/">Mapbox</a> © <a href="http://www.openstreetmap.org/copyright">OpenStreetMap</a>'
    }).addTo(map);

@jywarren jywarren mentioned this issue Dec 29, 2020
Merged
@jywarren
Copy link
Member Author

Prioritizing this to fix https://publiclab.org/map

@jywarren
Copy link
Member Author

I bet this is the most important! The others seem layer specific, and aren't baselayers after all...

leaflet-environmental-layers/src/AllLayers.js

Line 71 in e971a95

var defaultBaseLayer = L.tileLayer('https://a.tiles.mapbox.com/v3/jywarren.map-lmrwb2em/{z}/{x}/{y}.png', {

I also see this in the example but i bet it is not using the one-line constructor so it may not be one we need to fix:

leaflet-environmental-layers/example/layers.js

Line 10 in e971a95

var baselayer1 = L.tileLayer(

jywarren added a commit that referenced this issue Dec 29, 2020
@jywarren
update AllLayers.js to new MapBox API
1af7df8 
re #491
@jywarren jywarren mentioned this issue Dec 29, 2020
Merged
@jywarren
Copy link
Member Author

moving to #493 !!!

jywarren added a commit that referenced this issue Dec 29, 2020
@jywarren
update AllLayers.js to new MapBox API (will need patch release) (#493)
d956cee 
* update AllLayers.js to new MapBox API

re #491

* fixes mapbox baselayers in example too

* bump v2.4.1 with new mapbox API
@jywarren
Copy link
Member Author

OK, and publishing...

@jywarren
Copy link
Member Author

cc @Sagarpreet regarding this new release! Not using the script yet but interested!

@jywarren
Copy link
Member Author

Done and it's staging over in publiclab/plots2#8904

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jywarren