Notes preview: Make Route Match Post and Get Requests #8755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
RuthNjeri
commented
Nov 19, 2020
•
- Fixes Add a new /preview route to open editor preview in new tab #8560 (<=== Add issue number here)
- Part of this discussion
- Does not display form data yet
|
|
|
Code Climate has analyzed commit f593838 and detected 0 issues on this pull request. View more on Code Climate. |
Codecov Report
@@ Coverage Diff @@
## main #8755 +/- ##
==========================================
+ Coverage 81.92% 82.04% +0.11%
==========================================
Files 100 100
Lines 5930 5930
==========================================
+ Hits 4858 4865 +7
+ Misses 1072 1065 -7
|
manchere
pushed a commit
to manchere/plots2
that referenced
this pull request
Feb 13, 2021
* many Todo's added * add notes preview * Update notes_controller_test.rb * remove draft on node preview method * check whether renaming to save_draft fails any tests * check that tests pass with the save_draft method * revert to draft and create issue * Javascript code that opens preview - Does not display form data yet * open preview in another tab * revise test and update window preview * update preview window * add location and image tag * update test with location * add image in preview tab * add location to preview * Update rich.html.erb * Remove TODO comment * fix preview during edit and tags notice * Add time * remove status from preview * replace preview_tags with override_tags * show location only when selected * codeclimate add space after comma * convert location details to floating values * make the zoom preview a float * remove twice float conversion of zoom * remove tag notice and override tags * improve location logic to prevent failing tests * remove complexity from preview function * make notes preview request both get and post Co-authored-by: sagarpreet-chadha <sagarpreet.chadha@flipkart.com> Co-authored-by: Sagarpreet Chadha <chadha.sagarpreet97@gmail.com>
lagunasmel
pushed a commit
to lagunasmel/plots2
that referenced
this pull request
Mar 2, 2021
* many Todo's added * add notes preview * Update notes_controller_test.rb * remove draft on node preview method * check whether renaming to save_draft fails any tests * check that tests pass with the save_draft method * revert to draft and create issue * Javascript code that opens preview - Does not display form data yet * open preview in another tab * revise test and update window preview * update preview window * add location and image tag * update test with location * add image in preview tab * add location to preview * Update rich.html.erb * Remove TODO comment * fix preview during edit and tags notice * Add time * remove status from preview * replace preview_tags with override_tags * show location only when selected * codeclimate add space after comma * convert location details to floating values * make the zoom preview a float * remove twice float conversion of zoom * remove tag notice and override tags * improve location logic to prevent failing tests * remove complexity from preview function * make notes preview request both get and post Co-authored-by: sagarpreet-chadha <sagarpreet.chadha@flipkart.com> Co-authored-by: Sagarpreet Chadha <chadha.sagarpreet97@gmail.com>
reginaalyssa
pushed a commit
to reginaalyssa/plots2
that referenced
this pull request
Oct 16, 2021
* many Todo's added * add notes preview * Update notes_controller_test.rb * remove draft on node preview method * check whether renaming to save_draft fails any tests * check that tests pass with the save_draft method * revert to draft and create issue * Javascript code that opens preview - Does not display form data yet * open preview in another tab * revise test and update window preview * update preview window * add location and image tag * update test with location * add image in preview tab * add location to preview * Update rich.html.erb * Remove TODO comment * fix preview during edit and tags notice * Add time * remove status from preview * replace preview_tags with override_tags * show location only when selected * codeclimate add space after comma * convert location details to floating values * make the zoom preview a float * remove twice float conversion of zoom * remove tag notice and override tags * improve location logic to prevent failing tests * remove complexity from preview function * make notes preview request both get and post Co-authored-by: sagarpreet-chadha <sagarpreet.chadha@flipkart.com> Co-authored-by: Sagarpreet Chadha <chadha.sagarpreet97@gmail.com>
billymoroney1
pushed a commit
to billymoroney1/plots2
that referenced
this pull request
Dec 28, 2021
* many Todo's added * add notes preview * Update notes_controller_test.rb * remove draft on node preview method * check whether renaming to save_draft fails any tests * check that tests pass with the save_draft method * revert to draft and create issue * Javascript code that opens preview - Does not display form data yet * open preview in another tab * revise test and update window preview * update preview window * add location and image tag * update test with location * add image in preview tab * add location to preview * Update rich.html.erb * Remove TODO comment * fix preview during edit and tags notice * Add time * remove status from preview * replace preview_tags with override_tags * show location only when selected * codeclimate add space after comma * convert location details to floating values * make the zoom preview a float * remove twice float conversion of zoom * remove tag notice and override tags * improve location logic to prevent failing tests * remove complexity from preview function * make notes preview request both get and post Co-authored-by: sagarpreet-chadha <sagarpreet.chadha@flipkart.com> Co-authored-by: Sagarpreet Chadha <chadha.sagarpreet97@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.