Skip to content

Commit

Permalink
Notes preview: Make Route Match Post and Get Requests (publiclab#8755)
Browse files Browse the repository at this point in the history
* many Todo's added

* add notes preview

* Update notes_controller_test.rb

* remove draft on node preview method

* check whether renaming to save_draft fails any tests

* check that tests pass with the save_draft method

* revert to draft and create issue

* Javascript code that opens preview

- Does not display form data yet

* open preview in another tab

* revise test and update window preview

* update preview window

* add location and image tag

* update test with location

* add image in preview tab

* add location to preview

* Update rich.html.erb

* Remove TODO comment

* fix preview during edit and tags notice

* Add time

* remove status from preview

* replace preview_tags with override_tags

* show location only when selected

* codeclimate add space after comma

* convert location details to floating values

* make the zoom preview a float

* remove twice float conversion of zoom

* remove tag notice and override tags

* improve location logic to prevent failing tests

* remove complexity from preview function

* make notes preview request both get and post

Co-authored-by: sagarpreet-chadha <sagarpreet.chadha@flipkart.com>
Co-authored-by: Sagarpreet Chadha <chadha.sagarpreet97@gmail.com>
  • Loading branch information
3 people authored and manchere committed Feb 13, 2021
1 parent 2272d87 commit 3b52c26
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion config/routes.rb
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@
get 'notes/liked' => 'notes#liked'
get 'notes/image/:id' => 'notes#image'
get 'notes/delete/:id' => 'notes#delete'
post 'notes/preview' => 'notes#preview'
match 'notes/preview', to: 'notes#preview', via: [:post, :get]
post 'notes/delete/:id' => 'notes#delete'
post 'notes/update/:id' => 'notes#update'
post 'notes/create' => 'notes#create'
Expand Down

0 comments on commit 3b52c26

Please sign in to comment.