Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notes preview: Make Route Match Post and Get Requests #8755

Merged
merged 32 commits into from
Nov 23, 2020
Merged

Notes preview: Make Route Match Post and Get Requests #8755

Changes from all commits
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
751adb8
many Todo's added
Sagarpreet Oct 17, 2020
0e1e896
add notes preview
RuthNjeri Oct 19, 2020
a25f169
Update notes_controller_test.rb
sagarpreet-chadha Oct 25, 2020
50bc158
remove draft on node preview method
RuthNjeri Oct 26, 2020
bb4675c
check whether renaming to save_draft fails any tests
RuthNjeri Oct 28, 2020
d55bbb7
check that tests pass with the save_draft method
RuthNjeri Oct 28, 2020
2b86bcb
revert to draft and create issue
RuthNjeri Oct 28, 2020
863778b
Javascript code that opens preview
RuthNjeri Oct 28, 2020
e21de8d
Merge branch 'main' into notes_preview
RuthNjeri Nov 3, 2020
33fe809
open preview in another tab
RuthNjeri Nov 3, 2020
35a237c
revise test and update window preview
RuthNjeri Nov 3, 2020
beaa860
update preview window
RuthNjeri Nov 3, 2020
ed09568
add location and image tag
RuthNjeri Nov 4, 2020
b5d6418
update test with location
RuthNjeri Nov 4, 2020
a0dd372
add image in preview tab
RuthNjeri Nov 4, 2020
bf43f2f
add location to preview
RuthNjeri Nov 4, 2020
1dcb135
Update rich.html.erb
sagarpreet-chadha Nov 5, 2020
d888cff
Remove TODO comment
sagarpreet-chadha Nov 5, 2020
4a5eb7a
fix preview during edit and tags notice
RuthNjeri Nov 5, 2020
d3a521c
Add time
sagarpreet-chadha Nov 5, 2020
f933bc2
remove status from preview
RuthNjeri Nov 8, 2020
b678d39
replace preview_tags with override_tags
RuthNjeri Nov 9, 2020
1f1b91e
show location only when selected
RuthNjeri Nov 9, 2020
71b7e18
codeclimate add space after comma
RuthNjeri Nov 9, 2020
a4e1b8b
convert location details to floating values
RuthNjeri Nov 10, 2020
2dc0a0b
make the zoom preview a float
RuthNjeri Nov 10, 2020
f259601
remove twice float conversion of zoom
RuthNjeri Nov 10, 2020
fda360c
remove tag notice and override tags
RuthNjeri Nov 11, 2020
c5c10a0
improve location logic to prevent failing tests
RuthNjeri Nov 11, 2020
1a2d3aa
remove complexity from preview function
RuthNjeri Nov 11, 2020
5704829
make notes preview request both get and post
RuthNjeri Nov 19, 2020
f593838
Merge branch 'main' into notes_preview
RuthNjeri Nov 19, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion config/routes.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@
get 'notes/liked' => 'notes#liked'
get 'notes/image/:id' => 'notes#image'
get 'notes/delete/:id' => 'notes#delete'
post 'notes/preview' => 'notes#preview'
match 'notes/preview', to: 'notes#preview', via: [:post, :get]
post 'notes/delete/:id' => 'notes#delete'
post 'notes/update/:id' => 'notes#update'
post 'notes/create' => 'notes#create'
Expand Down