Email settings documentation #3140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
|
Hi @jywarren could you please review the documentation, should I also add the file location where I have used these tags in conditions to control settings? Thanks! |
jywarren
reviewed
Jul 26, 2018
doc/EMAIL.md
Outdated
| | Email Settings | User Tag | | ||
| | ------------- | ------------- | | ||
| | Notification by email for comments on your posts | notify-comment-direct:false | |
There was a problem hiding this comment.
Looks great, maybe we can have a column like Default showing the default setting, and the User Tag could say User tag to override default ? What do you think?
There was a problem hiding this comment.
and, i like the idea of linking to the lines of code!
There was a problem hiding this comment.
ok, I will make the changes. Thanks!
5 tasks
|
@jywarren plz review this PR. Thanks! |
|
Awesome. Thanks!!! Also, nice new picture! Maybe time to update mine! 📸 |
|
Thanks @jywarren 😬 ! Definitely, go for it! |
stefannibrasil
pushed a commit
to milaaraujo/plots2
that referenced
this pull request
Aug 3, 2018
* Email settings documentation * alerts bug * test res * updated doc
SrinandanPai
pushed a commit
to SrinandanPai/plots2
that referenced
this pull request
May 5, 2019
* Email settings documentation * alerts bug * test res * updated doc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3141
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake testfixes #0000-style reference to original issue #@publiclab/reviewersfor help, in a comment belowIf tests do fail, click on the red
Xto learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
We have a loose schedule of reviewing and pulling in changes every Tuesday and Friday, and publishing changes on Fridays.
Thanks!