Link addition to email for marking comment as spam

[grvsachdeva]

Fixes #3137

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

• tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
• code is in uniquely-named feature branch and has no merge conflicts
• PR is descriptively titled
• PR body includes fixes #0000-style reference to original issue #
• ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

We have a loose schedule of reviewing and pulling in changes every Tuesday and Friday, and publishing changes on Fridays.

Thanks!

[grvsachdeva]

Hi @jywarren @publiclab/soc anyone facing this issue

Thanks!

[stefannibrasil]

we are having the same error on #3114 and #3134

[grvsachdeva]

yes @stefannibrasil, my previous PR #3140 also failed. Let's wait for @jywarren and @icarito .

[plotsbot]

	1 Message
📖	@Gauravano Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.

Generated by 🚫 Danger

[grvsachdeva]

@jywarren please review this PR. Thanks!

[jywarren]

So here's what I'm worried about, are we notifying in a bulk BCC, or do we actually have unique user record each time it's sent?

I can't find where this is used to see what the @user variable is, but let's check!

https://github.com/publiclab/plots2/search?q=CommentMailer.notify&unscoped_q=CommentMailer.notify

[grvsachdeva]

Each time a new comment is created this CommentMailer.notify send emails to users subscribed to the tags or node. So, I have added these buttons only on normal notification emails.
Here's the effective mailer https://github.com/publiclab/plots2/blob/master/app/mailers/comment_mailer.rb#L7-L12

[grvsachdeva]

@jywarren

[jywarren]

yeah, that's great! I just want to know where user is specified -- like, do you know where this .notify() is called from, so we can be sure it represents the recipient user instead of the comment author? I think we may want to rename the parameter a little bit to be sure of it, since user is ambiguous, you know?

[grvsachdeva]

here it is @jywarren
https://github.com/publiclab/plots2/blob/master/app/models/comment.rb#L124-L130

[jywarren]

perfect! OK, do you want to change the parameter name to `recipient` or do you think we're OK here? Thanks!

…

On Wed, Aug 1, 2018 at 11:03 AM Gaurav Sachdeva ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In app/views/comment_mailer/notify.html.erb <#3163 (comment)>: > @@ -14,6 +14,13 @@ Hi! There's been a response to a discussion you're involved in. Do NOT reply to <hr /> +<p>Look like spam? + <% if @user.can_moderate? %> here it is @jywarren <https://github.com/jywarren> https://github.com/publiclab/plots2/blob/master/app/models/comment.rb#L124-L130 — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#3163 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABfJ62OIakwucwQn6MDph4SzNkK9zGlks5uMcMJgaJpZM4VlDdx> .

[grvsachdeva]

@jywarren I can change the name but the whole comment_mailer.rb file is using @ user. So, should I change it to recipient in notify_method only or everywhere. Thanks!

[jywarren]

ok, well we can also do that in a follow-up PR. OK, let's see how this does!