Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flash[:warning] appearing on subsequent pages #3141

Closed
jywarren opened this issue Jul 24, 2018 · 5 comments · Fixed by #3140
Closed

flash[:warning] appearing on subsequent pages #3141

jywarren opened this issue Jul 24, 2018 · 5 comments · Fixed by #3140

Comments

@jywarren
Copy link
Member

Hi, @Gauravano - this isn't exclusively related to drafts, but it did come up there. I've noticed flash messages get "delayed" and shown on the wrong page, say, on subsequent page loads on unrelated pages. Can you try to reproduce this? It did happen when viewing a draft page. I think it may happen for other interactions as well.

I'd love some help trying to track this down and solving it! Thanks!

@grvsachdeva
Copy link
Member

Hi @jywarren I am able to find one such occurrence while visiting the draft page if we visit any other page, then alert remains there. I am resolving it in #3140 . Any more instances which needs to resolve? Thanks!

@grvsachdeva
Copy link
Member

Tracked one more instance of this issue

second_instance

@grvsachdeva
Copy link
Member

One more instance
another_instance

All the flash alerts at application.rb are showing this behaviour, changing them to flash.now has resolved the issue.

@jywarren
Copy link
Member Author

jywarren commented Jul 24, 2018 via email

@grvsachdeva
Copy link
Member

Hi @jywarren sorry, I am unable to trace OpenId one, plz ping me the route if you come across any other instance. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants