Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add eslint, lint-staged and Husky #549

Closed
wants to merge 8 commits into from
Closed

Add eslint, lint-staged and Husky #549

wants to merge 8 commits into from

Conversation

keshav234156
Copy link
Member

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with grunt jasmine
  • code is in uniquely-named feature branch and has no merge conflicts
  • PR is descriptively titled
  • PR body includes fixes #0000-style reference to original issue #
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

We have a loose schedule of reviewing and pulling in changes every Tuesday and Friday, and publishing changes on Fridays.

Thanks!

anshukaira and others added 7 commits June 17, 2020 19:04
Co-authored-by: Cess <cessmbuguar@gmail.com>
adds .vscode in .gitignore
adds _SpecRunner.html in .gitignore

Co-authored-by: Emily Ashley <15912063+emilyashley@users.noreply.github.com>
Co-authored-by: Govind Goel <52847415+govindgoel@users.noreply.github.com>
Co-authored-by: Cess <cessmbuguar@gmail.com>
@keshav234156
Copy link
Member Author

Previous similar PR but with merge conflicts
#519

@keshav234156
Copy link
Member Author

keshav234156 commented Jun 30, 2020

It passed!.
Earlier error was occurring as we can't replace all double quotes " " with single quote ' '

@jywarren
Copy link
Member

Hi @keshav234156 ! Awesome. Can you try force-pushing git push -f origin add-esli (i think) this to the original PR so the conversation is preserved and linked clearly? Thank you!

@keshav234156
Copy link
Member Author

I can't force push as everything is upto-date. The branch of the previous PR was add-eslint. I made a new branch as there were many merge conflicts that weren't possible to fix including in package-lock.json and dist folder. So I made a new branch

@jywarren
Copy link
Member

Ah, ok, i get it! But maybe you can do git push -f origin HEAD:add-eslint? I think that should work!

@keshav234156
Copy link
Member Author

done!! It was totally a new thing to me. Thanks!! #519

@jywarren
Copy link
Member

😄 Great! Moving back to #519 then!

@jywarren jywarren closed this Jul 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants