-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add eslint, lint-staged and Husky #549
Conversation
Co-authored-by: Cess <cessmbuguar@gmail.com>
adds .vscode in .gitignore adds _SpecRunner.html in .gitignore Co-authored-by: Emily Ashley <15912063+emilyashley@users.noreply.github.com> Co-authored-by: Govind Goel <52847415+govindgoel@users.noreply.github.com> Co-authored-by: Cess <cessmbuguar@gmail.com>
Previous similar PR but with merge conflicts |
It passed!. |
Hi @keshav234156 ! Awesome. Can you try force-pushing |
I can't force push as everything is upto-date. The branch of the previous PR was add-eslint. I made a new branch as there were many merge conflicts that weren't possible to fix including in package-lock.json and dist folder. So I made a new branch |
Ah, ok, i get it! But maybe you can do |
done!! It was totally a new thing to me. Thanks!! #519 |
😄 Great! Moving back to #519 then! |
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
grunt jasmine
fixes #0000
-style reference to original issue #@publiclab/reviewers
for help, in a comment belowIf tests do fail, click on the red
X
to learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
We have a loose schedule of reviewing and pulling in changes every Tuesday and Friday, and publishing changes on Fridays.
Thanks!