Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: adds missing entries in .gitignore #423

Merged
merged 4 commits into from
Jun 17, 2020

Conversation

shreyaa-s-zz
Copy link
Collaborator

@shreyaa-s-zz shreyaa-s-zz commented Mar 17, 2020

fixes #422

adds .vscode in .gitignore
adds _SpecRunner.html in .gitignore

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with grunt jasmine
  • code is in uniquely-named feature branch and has no merge conflicts
  • PR is descriptively titled
  • PR body includes fixes #0000-style reference to original issue #
  • ask @publiclab/reviewers for help, in a comment below

Thanks!

adds .vscode in .gitignore
adds _SpecRunner.html in .gitignore
@welcome
Copy link

welcome bot commented Mar 17, 2020

Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help.
Please make sure you've bumped up the version number in the repository's package.json file and that you've incorporated your changes in the /dist/ sub-directory.
Dangerbot will test out your code and reply in a bit with some pointers and requests.
Also please refer here for installation help 💿
There may be some errors, but don't worry! We'll work through them with you! 👍🎉😄
It would be great if you can tell us your Twitter handle so we can thank you properly?

@shreyaa-s-zz
Copy link
Collaborator Author

@jywarren Hey i dont know why the checks are failing. I only made changes in the .gitignore file. Can you please help me out? Thanks.

@cesswairimu cesswairimu merged commit f537064 into publiclab:master Jun 17, 2020
@cesswairimu
Copy link
Collaborator

Thanks everyone 🎉

@cesswairimu cesswairimu mentioned this pull request Jun 17, 2020
5 tasks
jywarren pushed a commit that referenced this pull request Jul 14, 2020
* updated privacy link (#413)

Co-authored-by: Cess <cessmbuguar@gmail.com>

* FIX: adds missing entries in .gitignore (#423)

adds .vscode in .gitignore
adds _SpecRunner.html in .gitignore

Co-authored-by: Emily Ashley <15912063+emilyashley@users.noreply.github.com>
Co-authored-by: Govind Goel <52847415+govindgoel@users.noreply.github.com>
Co-authored-by: Cess <cessmbuguar@gmail.com>

* added eslint, Husky and lint-staged

Co-authored-by: Kaira Hiwatari <46723211+anshukaira@users.noreply.github.com>
Co-authored-by: Cess <cessmbuguar@gmail.com>
Co-authored-by: Shreya Sharma <55884943+shreyaa-s@users.noreply.github.com>
Co-authored-by: Emily Ashley <15912063+emilyashley@users.noreply.github.com>
Co-authored-by: Govind Goel <52847415+govindgoel@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing entries in .gitignore
5 participants