updated privacy link fix #366

[anshukaira]

Fixes #366
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

• tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with grunt jasmine
• code is in uniquely-named feature branch and has no merge conflicts
• PR is descriptively titled
• PR body includes fixes #0000-style reference to original issue #
• ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

We have a loose schedule of reviewing and pulling in changes every Tuesday and Friday, and publishing changes on Fridays.

Thanks!

[welcome]

Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help.
Please make sure you've bumped up the version number in the repository's package.json file and that you've incorporated your changes in the /dist/ sub-directory.
Dangerbot will test out your code and reply in a bit with some pointers and requests.
Also please refer here for installation help 💿
There may be some errors, but don't worry! We'll work through them with you! 👍🎉😄
It would be great if you can tell us your Twitter handle so we can thank you properly?

[anshukaira]

I do not get that. What I need to do next??

[nstjean]

Yes! This is great!! The code is properly updated. Just a couple notes for next time: First, put Issue #000 in the pr message itself, not the title. This is because github creates a link for issues mentioned in the posts, and that helps us keep organized! And second I notice that you used the branch name patch-2, we ask that you use descriptive names. But this is just fine for this one! Thanks so much!

[anshukaira]

ohk! One more question that the way i did it was right? I ll remeber to use descriptive ways in my prs. Thank you so much

…

On Mon, Mar 9, 2020 at 11:31 PM Natalie St Jean ***@***.***> wrote: ***@***.**** approved this pull request. Yes! This is great!! The code is properly updated. Just a couple notes for next time: First, put Issue #000 in the pr message itself, not the title. This is because github creates a link for issues mentioned in the posts, and that helps us keep organized! And second I notice that you used the branch name patch-2, we ask that you use descriptive names. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#413?email_source=notifications&email_token=ALEPBC7ABITABLKRFBT3UVDRGU4IBA5CNFSM4LDYG24KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCYRT5WA#pullrequestreview-371408600>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ALEPBC345D3Q3O26VEFCDX3RGU4IBANCNFSM4LDYG24A> .

[VladimirMikulic]

Hi @anshukaira. Congratulations on your first completed issue here on Public Lab.
What to do next? I'll leave that up to you :)

It depends on your skillset. You can try a few other beginner issues and once you fill confident enough, you can move onto the harder ones.

If you have any question feel free to ask me or @nstjean.
Best of luck 🚀

[nstjean]

@anshukaira Yes it was right! Congrats! 🎉

[nstjean]

This is for issue #366

[cesswairimu]

travis taking forever...restarting

[cesswairimu]

Thanks @anshukaira for this 🚀 : and thanks @debck @nstjean and @keshav234156 for the reviews 🎉

[welcome]

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will likely be published to PublicLab.org in the next few days. In the meantime, can you tell us your Twitter handle so we can thank you properly?
Do join our weekly check-in to share your this week goal and the awesome work you did 😃.
Reach out to someone else working on theirs on Public Lab's code welcome page. Thanks!
Now that you've completed this, you can help someone else take their first step!
See: Public Lab's coding community!

Help others take their first step

Now that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌

https://code.publiclab.org

Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕

People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉

Read about how to help support another newcomer here, or find other ways to offer mutual support here.