Linux platform example app includes SHELL unconditionally. #7205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Force defines and linkages as such, otherwise compilation with GN without 'use shell' does not work. TODO as followup: if shell is really optional, build it as such in linux as well.
…cludes are already there
jelderton
approved these changes
May 27, 2021
bzbarsky-apple
approved these changes
May 27, 2021
|
If we check this in then we don't need #7204, right? |
mspang
approved these changes
May 27, 2021
yufengwangca
approved these changes
May 27, 2021
This reverts commit 7a172f3. Apparently link checker is not fully working and this broke doxygen.
gjc13
added a commit
to gjc13/connectedhomeip
that referenced
this pull request
May 28, 2021
Fix the TODO in project-chip#7205
gjc13
added a commit
to gjc13/connectedhomeip
that referenced
this pull request
May 28, 2021
Fix the TODO in project-chip#7205
gjc13
added a commit
to gjc13/connectedhomeip
that referenced
this pull request
May 28, 2021
Fix the TODO in project-chip#7205
nikita-s-wrk
pushed a commit
to nikita-s-wrk/connectedhomeip
that referenced
this pull request
Sep 23, 2021
…hip#7205) * Linux platform example app includes SHELL unconditionally. Force defines and linkages as such, otherwise compilation with GN without 'use shell' does not work. TODO as followup: if shell is really optional, build it as such in linux as well. * remove the enable shell arg alltogether - it does not work because includes are already there * Revert "Fix relative path for the markdown link (project-chip#7202)" This reverts commit 7a172f3. Apparently link checker is not fully working and this broke doxygen.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Force defines and linkages as such, otherwise compilation with GN
without 'use shell' does not work.
TODO as followup: if shell is really optional, build it as such in linux
as well.
Problem
Vanilla build with GN fails with:
Change overview
Make linux always compile with shell support. At least compilation passes
Testing
Success in compiling all with GN (failure is gone, code compiles)