Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[shell] make shell really optional in Linux #7221

Closed
wants to merge 1 commit into from

Conversation

gjc13
Copy link
Contributor

@gjc13 gjc13 commented May 28, 2021

Problem

Fix the TODO in #7205

Change overview

Add global chip_shell gn args and use it as the only flag to enable/disable shell.

Testing

Build with gn gen out/debug --args='chip_shell=false' and gn gen out/debug --args='chip_shell=true'

@gjc13 gjc13 force-pushed the linux-shell-optional branch from e91f434 to f09922a Compare May 28, 2021 08:33
@andy31415
Copy link
Contributor

andy31415 commented May 31, 2021

Why do we want shell to be optional on linux?

Case for not having it optional: less config options, less likely for a build path to become stale and unmaintained.
If we do not have a sepecific use case for each of "with shell" and "without shell" it seems easier to just enable it always.

@gjc13 gjc13 closed this Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants