Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[shell] enable shell as an optional module in apps (#7080)" #7204

Closed

Conversation

bzbarsky-apple
Copy link
Contributor

This reverts commit c8f286f because
the result does not compile.

Fixes #7200

Problem

Tree does not build.

Change overview

Revert the PR that makes it not build.

Testing

How was this tested? (at least one bullet point required)

  • ./gn_build.sh run locally at toplevel of the tree.

@github-actions
Copy link

Size increase report for "nrfconnect-example-build" from c2cc13d

File Section File VM
chip-shell.elf device_handles 8 8
chip-shell.elf text 8 8
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-shell.elf and ./pull_artifact/chip-shell.elf:

sections,vmsize,filesize
.debug_loc,0,533
.debug_str,0,311
.strtab,0,222
.symtab,0,208
.debug_frame,0,132
.debug_aranges,0,48
.debug_ranges,0,24
.debug_line,0,11
device_handles,8,8
text,8,8
.shstrtab,0,2
.debug_abbrev,0,-450
.debug_info,0,-2193

Comparing ./master_artifact/chip-lock.elf and ./pull_artifact/chip-lock.elf:

sections,vmsize,filesize


@bzbarsky-apple
Copy link
Contributor Author

Addressed by #7205

@bzbarsky-apple bzbarsky-apple deleted the backout-7080 branch May 28, 2021 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
config examples hotfix urgent fix needed, can bypass review lib
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gn_build.sh compilation failure happens after PR 7080 landed
1 participant