[3rd-party] update openthread and ot-br-posix #5062

wgtdkp · 2021-02-28T10:01:00Z

Summary of Changes

Update OpenThread and ot-br-posix to include the latest SRP and Thread Duckhorn Border Router changes.

Depends-On:

[efr32] efr32 example is broken openthread/openthread#6218 (the issue is fixed within CHIP).
[dbus] remove inclusion of code_utils.hpp in dbus api header openthread/ot-br-posix#713

mspang · 2021-03-01T04:12:34Z

Need to figure out the EFR32 update. @jepenven-silabs

mspang · 2021-03-01T04:13:10Z

Also, build is broken on VerifyOrDie conflict.

wgtdkp · 2021-03-01T08:24:12Z

Need to figure out the EFR32 update. @jepenven-silabs

@mspang @jepenven-silabs I submitted the issue in openthread: openthread/openthread#6218

wgtdkp · 2021-03-01T08:27:15Z

Also, build is broken on VerifyOrDie conflict.

I created openthread/ot-br-posix#713 for this.

jepenven-silabs · 2021-03-01T15:39:28Z

Need to figure out the EFR32 update. @jepenven-silabs

@mspang @jepenven-silabs I submitted the issue in openthread: openthread/openthread#6218

The failure on the CHIP side of things seems to be related to some headers files missing inside the sdk gn config. I'll take a quick look at this later today. @wgtdkp

jepenven-silabs · 2021-03-02T00:36:54Z

@wgtdkp @mspang Currently working on a fix for the EFR32. I'll post the commit once the fix is complete so you can cherry-pick it on top of your branch

todo · 2021-03-02T02:54:22Z

have qpg6100 openthread platform implementation defines the APIs.

connectedhomeip/src/platform/qpg6100/Logging.cpp

Lines 128 to 138 in eb836e2

    
           // TODO: have qpg6100 openthread platform implementation defines the APIs. 
        
           // It is not perfect to have the openthread platform calloc/free 
        
           // APIs defined here. If a dedicated source file (e.g. Memory.cpp) 
        
           // that includes only the two functions is used, the target file 
        
           // Memory.o will be thrown away whening linking the libary because 
        
           // there is no one referring the symbols (We are not linking 
        
           // the 'platform' library against openthread). 
        
           extern "C" void * otPlatCAlloc(size_t aNum, size_t aSize) 
        
           { 
        
               return CHIPPlatformMemoryCalloc(aNum, aSize); 
        
           }

This comment was generated by todo based on a `TODO` comment in `eb836e2` in #5062. cc @wgtdkp.

wgtdkp · 2021-03-02T06:01:20Z

@jepenven-silabs Thanks! It works.

@mspang Seems the CI failures have been resolved, PTAL.

(There are several commits, please do squash merge.

- Remove all of the duplicate include_dirs that were needed due to missing dependencies & improper use of private deps. - Add back an retargetserial.c file which is needed for this build. It was removed in fc59bd2 ("[3rd-party] update openthread and ot-br-posix (project-chip#5062)") - Remove some unusual whitespace in defines

- Remove all of the duplicate include_dirs that were needed due to missing dependencies & improper use of private deps. - Add back an retargetserial.c file which is needed for this build. It was removed in fc59bd2 ("[3rd-party] update openthread and ot-br-posix (#5062)") - Remove some unusual whitespace in defines

- Remove all of the duplicate include_dirs that were needed due to missing dependencies & improper use of private deps. - Add back an retargetserial.c file which is needed for this build. It was removed in fc59bd2 ("[3rd-party] update openthread and ot-br-posix (project-chip#5062)") - Define the pigweed_lighting debug API in a common place. This means we need to move the enable_pw_rpc to that place, too. - Add missing bits to CHIPProjectConfig.h needed after c99bef7 ("[EFR32] BLE Advertissement fixes and change default pin code (project-chip#5503)") Tested via gn gen out/with_pw_rpc --args='import("//with_pw_rpc.gni")' ninja -C out/with_pw_rpc Note it is still broken due to OpenThread serial conflict.

- Remove all of the duplicate include_dirs that were needed due to missing dependencies & improper use of private deps. - Add back an retargetserial.c file which is needed for this build. It was removed in fc59bd2 ("[3rd-party] update openthread and ot-br-posix (project-chip#5062)") - Remove some unusual whitespace in defines

- Remove all of the duplicate include_dirs that were needed due to missing dependencies & improper use of private deps. - Add back an retargetserial.c file which is needed for this build. It was removed in fc59bd2 ("[3rd-party] update openthread and ot-br-posix (project-chip#5062)") - Define the pigweed_lighting debug API in a common place. This means we need to move the enable_pw_rpc to that place, too. - Add missing bits to CHIPProjectConfig.h needed after c99bef7 ("[EFR32] BLE Advertissement fixes and change default pin code (project-chip#5503)") Tested via gn gen out/with_pw_rpc --args='import("//with_pw_rpc.gni")' ninja -C out/with_pw_rpc Note it is still broken due to OpenThread serial conflict. Clean up and add comments for the uart api remap OT uart functions to use our uart api.

- Remove all of the duplicate include_dirs that were needed due to missing dependencies & improper use of private deps. - Add back an retargetserial.c file which is needed for this build. It was removed in fc59bd2 ("[3rd-party] update openthread and ot-br-posix (project-chip#5062)") - Define the pigweed_lighting debug API in a common place. This means we need to move the enable_pw_rpc to that place, too. - Add missing bits to CHIPProjectConfig.h needed after c99bef7 ("[EFR32] BLE Advertissement fixes and change default pin code (project-chip#5503)") Tested via gn gen out/with_pw_rpc --args='import("//with_pw_rpc.gni")' ninja -C out/with_pw_rpc Note it is still broken due to OpenThread serial conflict.

- Remove all of the duplicate include_dirs that were needed due to missing dependencies & improper use of private deps. - Add back an retargetserial.c file which is needed for this build. It was removed in fc59bd2 ("[3rd-party] update openthread and ot-br-posix (#5062)") - Define the pigweed_lighting debug API in a common place. This means we need to move the enable_pw_rpc to that place, too. - Add missing bits to CHIPProjectConfig.h needed after c99bef7 ("[EFR32] BLE Advertissement fixes and change default pin code (#5503)") Tested via gn gen out/with_pw_rpc --args='import("//with_pw_rpc.gni")' ninja -C out/with_pw_rpc Note it is still broken due to OpenThread serial conflict.

…5628) - Remove all of the duplicate include_dirs that were needed due to missing dependencies & improper use of private deps. - Add back an retargetserial.c file which is needed for this build. It was removed in fc59bd2 ("[3rd-party] update openthread and ot-br-posix (project-chip#5062)") - Define the pigweed_lighting debug API in a common place. This means we need to move the enable_pw_rpc to that place, too. - Add missing bits to CHIPProjectConfig.h needed after c99bef7 ("[EFR32] BLE Advertissement fixes and change default pin code (project-chip#5503)") Tested via gn gen out/with_pw_rpc --args='import("//with_pw_rpc.gni")' ninja -C out/with_pw_rpc Note it is still broken due to OpenThread serial conflict.

- Remove all of the duplicate include_dirs that were needed due to missing dependencies & improper use of private deps. - Add back an retargetserial.c file which is needed for this build. It was removed in fc59bd2 ("[3rd-party] update openthread and ot-br-posix (project-chip#5062)") - Define the pigweed_lighting debug API in a common place. This means we need to move the enable_pw_rpc to that place, too. - Add missing bits to CHIPProjectConfig.h needed after c99bef7 ("[EFR32] BLE Advertissement fixes and change default pin code (project-chip#5503)") Tested via gn gen out/with_pw_rpc --args='import("//with_pw_rpc.gni")' ninja -C out/with_pw_rpc Note it is still broken due to OpenThread serial conflict. Clean up and add comments for the uart api remap OT uart functions to use our uart api.

…read (#5648) * Rework uart functionality for pigweed to use silabs UARTDRV and DMA. Rework Uart.c to use a circular buffer and the uardrv dma for RX Remove from build the uart from openthread. Was causing issue with PW Add some weak empty implementations of now missing/unused Thread uart functions. Will remap those functions to use uart api implementation for efr32 in chip * Fix and clean up examples/lighting-app/efr32 RPC build - Remove all of the duplicate include_dirs that were needed due to missing dependencies & improper use of private deps. - Add back an retargetserial.c file which is needed for this build. It was removed in fc59bd2 ("[3rd-party] update openthread and ot-br-posix (#5062)") - Define the pigweed_lighting debug API in a common place. This means we need to move the enable_pw_rpc to that place, too. - Add missing bits to CHIPProjectConfig.h needed after c99bef7 ("[EFR32] BLE Advertissement fixes and change default pin code (#5503)") Tested via gn gen out/with_pw_rpc --args='import("//with_pw_rpc.gni")' ninja -C out/with_pw_rpc Note it is still broken due to OpenThread serial conflict. Clean up and add comments for the uart api remap OT uart functions to use our uart api. * Restyled by whitespace * Restyled by clang-format * Restyled by gn Co-authored-by: Michael Spang <spang@google.com> Co-authored-by: Restyled.io <commits@restyled.io>

pullapprove bot requested review from andy31415, bzbarsky-apple, chrisdecenzo, hawk248, jelderton, msandstedt, mspang, saurabhst and woody-apple February 28, 2021 10:01

[3rd-party] update openthread and ot-br-posix

2fe5440

wgtdkp force-pushed the update-ot-otbr branch from da36703 to 2fe5440 Compare February 28, 2021 10:20

boring-cyborg bot added examples platform labels Feb 28, 2021

pullapprove bot requested a review from pan-apple February 28, 2021 10:21

This was referenced Mar 1, 2021

[efr32] efr32 example is broken openthread/openthread#6218

Closed

[dbus] remove inclusion of code_utils.hpp in dbus api header openthread/ot-br-posix#713

Merged

restyled-io bot mentioned this pull request Mar 1, 2021

Restyle [3rd-party] update openthread and ot-br-posix #5073

Closed

wgtdkp force-pushed the update-ot-otbr branch 2 times, most recently from 9887db4 to 2a20a6c Compare March 1, 2021 12:20

wgtdkp added 2 commits March 2, 2021 10:39

add platform API implementations for qorvo devcies

8427f6c

update otbr to include fixes

3eace9e

wgtdkp force-pushed the update-ot-otbr branch from 2a20a6c to 3eace9e Compare March 2, 2021 02:40

add documentation

eb836e2

Restyled by gn

512ddbc

restyled-io bot mentioned this pull request Mar 2, 2021

Restyle [3rd-party] update openthread and ot-br-posix #5094

Closed

andy31415 approved these changes Mar 2, 2021

View reviewed changes

jwhui approved these changes Mar 2, 2021

View reviewed changes

jelderton approved these changes Mar 2, 2021

View reviewed changes

saurabhst approved these changes Mar 2, 2021

View reviewed changes

mspang approved these changes Mar 2, 2021

View reviewed changes

mspang merged commit fc59bd2 into project-chip:master Mar 2, 2021

todo bot mentioned this pull request Mar 2, 2021

have qpg6100 openthread platform implementation defines the APIs. #5108

Closed

mspang mentioned this pull request Mar 20, 2021

Fix and clean up examples/pigweed-app/efr32 build #5513

Merged

mspang mentioned this pull request Mar 25, 2021

Fix and clean up examples/lighting-app/efr32 RPC build #5628

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[3rd-party] update openthread and ot-br-posix #5062

[3rd-party] update openthread and ot-br-posix #5062

wgtdkp commented Feb 28, 2021 •

edited

Loading

mspang commented Mar 1, 2021

mspang commented Mar 1, 2021

wgtdkp commented Mar 1, 2021

wgtdkp commented Mar 1, 2021

jepenven-silabs commented Mar 1, 2021 •

edited

Loading

jepenven-silabs commented Mar 2, 2021

todo bot commented Mar 2, 2021

wgtdkp commented Mar 2, 2021

[3rd-party] update openthread and ot-br-posix #5062

[3rd-party] update openthread and ot-br-posix #5062

Conversation

wgtdkp commented Feb 28, 2021 • edited Loading

Summary of Changes

mspang commented Mar 1, 2021

mspang commented Mar 1, 2021

wgtdkp commented Mar 1, 2021

wgtdkp commented Mar 1, 2021

jepenven-silabs commented Mar 1, 2021 • edited Loading

jepenven-silabs commented Mar 2, 2021

todo bot commented Mar 2, 2021

have qpg6100 openthread platform implementation defines the APIs.

This comment was generated by todo based on a TODO comment in eb836e2 in #5062. cc @wgtdkp.

wgtdkp commented Mar 2, 2021

wgtdkp commented Feb 28, 2021 •

edited

Loading

jepenven-silabs commented Mar 1, 2021 •

edited

Loading

This comment was generated by todo based on a `TODO` comment in `eb836e2` in #5062. cc @wgtdkp.