Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EFR32] BLE Advertissement fixes and change default pin code #5503

Merged
merged 5 commits into from
Mar 22, 2021
Merged

[EFR32] BLE Advertissement fixes and change default pin code #5503

merged 5 commits into from
Mar 22, 2021

Conversation

jmartinez-silabs
Copy link
Member

@jmartinez-silabs jmartinez-silabs commented Mar 19, 2021 •
edited
Loading

Problem

Default setup Pin Code 12345678 is invalid
BLE always advertises the same address wich is the device identity address
BLE always advertises at the same interval until provisioned.

Summary of Changes

  • Change default SetupPincode value for lock and light example, can be changed by build argument
  • Set random BLE advertissement address at advertissement start.
  • Add Advertissement times outs -> fast advertisement (25ms)intervals from 0 to 30s, slow adv interval (500ms) from 30s to 15m, stop advertissement after that

@jmartinez-silabs
Fix for test event 1
21bbfe9 
- Change default SetupPincode value for lock adn light example, can be changed with build arguments
- Set random BLE advertissement addresse at advertissement start.
- Add Advertissement times outs -> fast advertisement 25ms from 0 to 30s, slow adv 500ms 30s to 15m, stop adv after that
@restyled-io restyled-io bot mentioned this pull request Mar 19, 2021
Closed
@woody-apple woody-apple merged commit c99bef7 into project-chip:master Mar 22, 2021
jmartinez-silabs added a commit to jmartinez-silabs/connectedhomeip that referenced this pull request Mar 22, 2021
@jmartinez-silabs
Branch with Test_event_1 tag + cherry pick of PR project-chip#5503 to…
e640974 
… add ble advertissement timeouts

- fix conflicts from Cherry picking due to api modified in master vs test_event_1 tag
jmartinez-silabs added a commit to jmartinez-silabs/connectedhomeip that referenced this pull request Mar 22, 2021
@jmartinez-silabs
Branch with Test_event_1 tag + cherry pick of PR project-chip#5503 to…
f0f84e7 
… add ble advertissement timeouts

- fix conflicts from Cherry picking due to api modified in master vs test_event_1 tag
andy31415 pushed a commit that referenced this pull request Mar 22, 2021
@jmartinez-silabs @andreilitvin
[EFR32] BLE Advertissement fixes and change default pin code (#5503)
d7b2dae 
* Fix for test event 1
- Change default SetupPincode value for lock adn light example, can be changed with build arguments
- Set random BLE advertissement addresse at advertissement start.
- Add Advertissement times outs -> fast advertisement 25ms from 0 to 30s, slow adv 500ms 30s to 15m, stop adv after that

* Restyled by whitespace

* Restyled by clang-format

* Restyled by gn

* Fix build, missed function delete by rebase.

Co-authored-by: Restyled.io <commits@restyled.io>

Conflicts:
	src/platform/EFR32/BLEManagerImpl.cpp
@jmartinez-silabs jmartinez-silabs deleted the ble_adv branch March 24, 2021 15:36
mspang added a commit to mspang/connectedhomeip that referenced this pull request Mar 25, 2021
@mspang
Fix and clean up examples/pigweed-app/efr32 build
beb2e08 
- Remove all of the duplicate include_dirs that were needed due
  to missing dependencies & improper use of private deps.
- Add back an retargetserial.c file which is needed for this build. It
  was removed in fc59bd2 ("[3rd-party] update openthread and
  ot-br-posix (project-chip#5062)")
- Define the pigweed_lighting debug API in a common place. This
  means we need to move the enable_pw_rpc to that place, too.
- Add missing bits to CHIPProjectConfig.h needed after c99bef7
  ("[EFR32] BLE Advertissement fixes and change default pin code
  (project-chip#5503)")

Tested via
  gn gen out/with_pw_rpc --args='import("//with_pw_rpc.gni")'
  ninja -C out/with_pw_rpc

Note it is still broken due to OpenThread serial conflict.
@mspang mspang mentioned this pull request Mar 25, 2021
Merged
mspang added a commit to mspang/connectedhomeip that referenced this pull request Mar 25, 2021
@mspang
Fix and clean up examples/lighting-app/efr32 RPC build
86caddf 
- Remove all of the duplicate include_dirs that were needed due
  to missing dependencies & improper use of private deps.
- Add back an retargetserial.c file which is needed for this build. It
  was removed in fc59bd2 ("[3rd-party] update openthread and
  ot-br-posix (project-chip#5062)")
- Define the pigweed_lighting debug API in a common place. This
  means we need to move the enable_pw_rpc to that place, too.
- Add missing bits to CHIPProjectConfig.h needed after c99bef7
  ("[EFR32] BLE Advertissement fixes and change default pin code
  (project-chip#5503)")

Tested via
  gn gen out/with_pw_rpc --args='import("//with_pw_rpc.gni")'
  ninja -C out/with_pw_rpc

Note it is still broken due to OpenThread serial conflict.
mspang added a commit to mspang/connectedhomeip that referenced this pull request Mar 25, 2021
@mspang
Fix and clean up examples/lighting-app/efr32 RPC build
e57e908 
- Remove all of the duplicate include_dirs that were needed due
  to missing dependencies & improper use of private deps.
- Add back an retargetserial.c file which is needed for this build. It
  was removed in fc59bd2 ("[3rd-party] update openthread and
  ot-br-posix (project-chip#5062)")
- Define the pigweed_lighting debug API in a common place. This
  means we need to move the enable_pw_rpc to that place, too.
- Add missing bits to CHIPProjectConfig.h needed after c99bef7
  ("[EFR32] BLE Advertissement fixes and change default pin code
  (project-chip#5503)")

Tested via
  gn gen out/with_pw_rpc --args='import("//with_pw_rpc.gni")'
  ninja -C out/with_pw_rpc

Note it is still broken due to OpenThread serial conflict.
jimlyall-q pushed a commit to jimlyall-q/connectedhomeip that referenced this pull request Mar 26, 2021
@jmartinez-silabs @restyled-commits @jimlyall-q
[EFR32] BLE Advertissement fixes and change default pin code (project…
5abf791 
…-chip#5503)

* Fix for test event 1
- Change default SetupPincode value for lock adn light example, can be changed with build arguments
- Set random BLE advertissement addresse at advertissement start.
- Add Advertissement times outs -> fast advertisement 25ms from 0 to 30s, slow adv 500ms 30s to 15m, stop adv after that

* Restyled by whitespace

* Restyled by clang-format

* Restyled by gn

* Fix build, missed function delete by rebase.

Co-authored-by: Restyled.io <commits@restyled.io>
jmartinez-silabs pushed a commit to jmartinez-silabs/connectedhomeip that referenced this pull request Mar 26, 2021
@mspang @jmartinez-silabs
Fix and clean up examples/lighting-app/efr32 RPC build
57ba071 
- Remove all of the duplicate include_dirs that were needed due
  to missing dependencies & improper use of private deps.
- Add back an retargetserial.c file which is needed for this build. It
  was removed in fc59bd2 ("[3rd-party] update openthread and
  ot-br-posix (project-chip#5062)")
- Define the pigweed_lighting debug API in a common place. This
  means we need to move the enable_pw_rpc to that place, too.
- Add missing bits to CHIPProjectConfig.h needed after c99bef7
  ("[EFR32] BLE Advertissement fixes and change default pin code
  (project-chip#5503)")

Tested via
  gn gen out/with_pw_rpc --args='import("//with_pw_rpc.gni")'
  ninja -C out/with_pw_rpc

Note it is still broken due to OpenThread serial conflict.

Clean up and add comments for the uart api
remap OT uart functions to use our uart api.
jmartinez-silabs pushed a commit to jmartinez-silabs/connectedhomeip that referenced this pull request Mar 26, 2021
@mspang @jmartinez-silabs
Fix and clean up examples/lighting-app/efr32 RPC build
dfdd77b 
- Remove all of the duplicate include_dirs that were needed due
  to missing dependencies & improper use of private deps.
- Add back an retargetserial.c file which is needed for this build. It
  was removed in fc59bd2 ("[3rd-party] update openthread and
  ot-br-posix (project-chip#5062)")
- Define the pigweed_lighting debug API in a common place. This
  means we need to move the enable_pw_rpc to that place, too.
- Add missing bits to CHIPProjectConfig.h needed after c99bef7
  ("[EFR32] BLE Advertissement fixes and change default pin code
  (project-chip#5503)")

Tested via
  gn gen out/with_pw_rpc --args='import("//with_pw_rpc.gni")'
  ninja -C out/with_pw_rpc

Note it is still broken due to OpenThread serial conflict.

Clean up and add comments for the uart api
remap OT uart functions to use our uart api.
jmartinez-silabs pushed a commit to jmartinez-silabs/connectedhomeip that referenced this pull request Mar 26, 2021
@mspang @jmartinez-silabs
Fix and clean up examples/lighting-app/efr32 RPC build
feac701 
- Remove all of the duplicate include_dirs that were needed due
  to missing dependencies & improper use of private deps.
- Add back an retargetserial.c file which is needed for this build. It
  was removed in fc59bd2 ("[3rd-party] update openthread and
  ot-br-posix (project-chip#5062)")
- Define the pigweed_lighting debug API in a common place. This
  means we need to move the enable_pw_rpc to that place, too.
- Add missing bits to CHIPProjectConfig.h needed after c99bef7
  ("[EFR32] BLE Advertissement fixes and change default pin code
  (project-chip#5503)")

Tested via
  gn gen out/with_pw_rpc --args='import("//with_pw_rpc.gni")'
  ninja -C out/with_pw_rpc

Note it is still broken due to OpenThread serial conflict.

Clean up and add comments for the uart api
remap OT uart functions to use our uart api.
jmartinez-silabs pushed a commit to jmartinez-silabs/connectedhomeip that referenced this pull request Mar 26, 2021
@mspang @jmartinez-silabs
Fix and clean up examples/lighting-app/efr32 RPC build
d0ead76 
- Remove all of the duplicate include_dirs that were needed due
  to missing dependencies & improper use of private deps.
- Add back an retargetserial.c file which is needed for this build. It
  was removed in fc59bd2 ("[3rd-party] update openthread and
  ot-br-posix (project-chip#5062)")
- Define the pigweed_lighting debug API in a common place. This
  means we need to move the enable_pw_rpc to that place, too.
- Add missing bits to CHIPProjectConfig.h needed after c99bef7
  ("[EFR32] BLE Advertissement fixes and change default pin code
  (project-chip#5503)")

Tested via
  gn gen out/with_pw_rpc --args='import("//with_pw_rpc.gni")'
  ninja -C out/with_pw_rpc

Note it is still broken due to OpenThread serial conflict.

Clean up and add comments for the uart api
remap OT uart functions to use our uart api.
jmartinez-silabs pushed a commit to jmartinez-silabs/connectedhomeip that referenced this pull request Mar 26, 2021
@mspang @jmartinez-silabs
Fix and clean up examples/lighting-app/efr32 RPC build
cd7a4ef 
- Remove all of the duplicate include_dirs that were needed due
  to missing dependencies & improper use of private deps.
- Add back an retargetserial.c file which is needed for this build. It
  was removed in fc59bd2 ("[3rd-party] update openthread and
  ot-br-posix (project-chip#5062)")
- Define the pigweed_lighting debug API in a common place. This
  means we need to move the enable_pw_rpc to that place, too.
- Add missing bits to CHIPProjectConfig.h needed after c99bef7
  ("[EFR32] BLE Advertissement fixes and change default pin code
  (project-chip#5503)")

Tested via
  gn gen out/with_pw_rpc --args='import("//with_pw_rpc.gni")'
  ninja -C out/with_pw_rpc

Note it is still broken due to OpenThread serial conflict.

Clean up and add comments for the uart api
remap OT uart functions to use our uart api.
mspang added a commit to mspang/connectedhomeip that referenced this pull request Mar 29, 2021
@mspang
Fix and clean up examples/lighting-app/efr32 RPC build
297be49 
- Remove all of the duplicate include_dirs that were needed due
  to missing dependencies & improper use of private deps.
- Add back an retargetserial.c file which is needed for this build. It
  was removed in fc59bd2 ("[3rd-party] update openthread and
  ot-br-posix (project-chip#5062)")
- Define the pigweed_lighting debug API in a common place. This
  means we need to move the enable_pw_rpc to that place, too.
- Add missing bits to CHIPProjectConfig.h needed after c99bef7
  ("[EFR32] BLE Advertissement fixes and change default pin code
  (project-chip#5503)")

Tested via
  gn gen out/with_pw_rpc --args='import("//with_pw_rpc.gni")'
  ninja -C out/with_pw_rpc

Note it is still broken due to OpenThread serial conflict.
mspang added a commit that referenced this pull request Mar 29, 2021
@mspang
Fix and clean up examples/lighting-app/efr32 RPC build (#5628)
05b6d6d 
- Remove all of the duplicate include_dirs that were needed due
  to missing dependencies & improper use of private deps.
- Add back an retargetserial.c file which is needed for this build. It
  was removed in fc59bd2 ("[3rd-party] update openthread and
  ot-br-posix (#5062)")
- Define the pigweed_lighting debug API in a common place. This
  means we need to move the enable_pw_rpc to that place, too.
- Add missing bits to CHIPProjectConfig.h needed after c99bef7
  ("[EFR32] BLE Advertissement fixes and change default pin code
  (#5503)")

Tested via
  gn gen out/with_pw_rpc --args='import("//with_pw_rpc.gni")'
  ninja -C out/with_pw_rpc

Note it is still broken due to OpenThread serial conflict.
jimlyall-q pushed a commit to jimlyall-q/connectedhomeip that referenced this pull request Mar 29, 2021
@mspang @jimlyall-q
Fix and clean up examples/lighting-app/efr32 RPC build (project-chip#…
d87fea3 
…5628)

- Remove all of the duplicate include_dirs that were needed due
  to missing dependencies & improper use of private deps.
- Add back an retargetserial.c file which is needed for this build. It
  was removed in fc59bd2 ("[3rd-party] update openthread and
  ot-br-posix (project-chip#5062)")
- Define the pigweed_lighting debug API in a common place. This
  means we need to move the enable_pw_rpc to that place, too.
- Add missing bits to CHIPProjectConfig.h needed after c99bef7
  ("[EFR32] BLE Advertissement fixes and change default pin code
  (project-chip#5503)")

Tested via
  gn gen out/with_pw_rpc --args='import("//with_pw_rpc.gni")'
  ninja -C out/with_pw_rpc

Note it is still broken due to OpenThread serial conflict.
jmartinez-silabs pushed a commit to jmartinez-silabs/connectedhomeip that referenced this pull request Mar 29, 2021
@mspang @jmartinez-silabs
Fix and clean up examples/lighting-app/efr32 RPC build
a591fcb 
- Remove all of the duplicate include_dirs that were needed due
  to missing dependencies & improper use of private deps.
- Add back an retargetserial.c file which is needed for this build. It
  was removed in fc59bd2 ("[3rd-party] update openthread and
  ot-br-posix (project-chip#5062)")
- Define the pigweed_lighting debug API in a common place. This
  means we need to move the enable_pw_rpc to that place, too.
- Add missing bits to CHIPProjectConfig.h needed after c99bef7
  ("[EFR32] BLE Advertissement fixes and change default pin code
  (project-chip#5503)")

Tested via
  gn gen out/with_pw_rpc --args='import("//with_pw_rpc.gni")'
  ninja -C out/with_pw_rpc

Note it is still broken due to OpenThread serial conflict.

Clean up and add comments for the uart api
remap OT uart functions to use our uart api.
mspang added a commit that referenced this pull request Mar 30, 2021
@jmartinez-silabs @mspang @restyled-commits
[EFR32] Rework uart api used for Pigweed and fix conflict with Openth…
25818db 
…read (#5648)

* Rework uart functionality for pigweed to use silabs UARTDRV and DMA.

Rework Uart.c to use a circular buffer and the uardrv dma for RX
Remove from build the uart from openthread. Was causing issue with PW
Add some weak empty implementations of now missing/unused Thread uart functions. Will remap those functions to use uart api implementation for efr32 in chip

* Fix and clean up examples/lighting-app/efr32 RPC build

- Remove all of the duplicate include_dirs that were needed due
  to missing dependencies & improper use of private deps.
- Add back an retargetserial.c file which is needed for this build. It
  was removed in fc59bd2 ("[3rd-party] update openthread and
  ot-br-posix (#5062)")
- Define the pigweed_lighting debug API in a common place. This
  means we need to move the enable_pw_rpc to that place, too.
- Add missing bits to CHIPProjectConfig.h needed after c99bef7
  ("[EFR32] BLE Advertissement fixes and change default pin code
  (#5503)")

Tested via
  gn gen out/with_pw_rpc --args='import("//with_pw_rpc.gni")'
  ninja -C out/with_pw_rpc

Note it is still broken due to OpenThread serial conflict.

Clean up and add comments for the uart api
remap OT uart functions to use our uart api.

* Restyled by whitespace

* Restyled by clang-format

* Restyled by gn

Co-authored-by: Michael Spang <spang@google.com>
Co-authored-by: Restyled.io <commits@restyled.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy31415 andy31415 andy31415 approved these changes

@woody-apple woody-apple woody-apple approved these changes

@jepenven-silabs jepenven-silabs jepenven-silabs approved these changes

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@jelderton jelderton Awaiting requested review from jelderton

@LuDuda LuDuda Awaiting requested review from LuDuda

@mspang mspang Awaiting requested review from mspang

@saurabhst saurabhst Awaiting requested review from saurabhst

Assignees
No one assigned
Labels
efr32 examples platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jmartinez-silabs @andy31415 @woody-apple @jepenven-silabs @restyled-commits