-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix and clean up examples/pigweed-app/efr32 build #5513
Fix and clean up examples/pigweed-app/efr32 build #5513
Conversation
450c17e
to
3f3e490
Compare
@jepenven-silabs How do we resolve the duplicate symbol error:
|
- Remove all of the duplicate include_dirs that were needed due to missing dependencies & improper use of private deps. - Add back an retargetserial.c file which is needed for this build. It was removed in fc59bd2 ("[3rd-party] update openthread and ot-br-posix (project-chip#5062)") - Remove some unusual whitespace in defines
3f3e490
to
b6a003a
Compare
@mspang I did some work to fix pigweed for efr32 after the Openthread submodule update brought some issues with the duplicate symbol error:. It is still on a branch as I wanted to make it better. retargetserial use the same IRQ that is used in the uart implementation in OT for the cli. This is the file that is built with OT subrepo that brings this conflict
It is also problematic for pigweed generally because OT calls efr32UartProcess periodicly and will get the data from the serial instead of the Pigweed functionnality if run on lighting example for example. So I removed that file "${openthread_root}/examples/platforms/efr32/src/uart.c", And wanted to reimplement those function in our side and make sure they don't do anything when the example is built for pigweed.
I was also reworking the UART driver to not use retargetserial and use dma |
- Remove all of the duplicate include_dirs that were needed due to missing dependencies & improper use of private deps. - Add back an retargetserial.c file which is needed for this build. It was removed in fc59bd2 ("[3rd-party] update openthread and ot-br-posix (project-chip#5062)") - Remove some unusual whitespace in defines
to missing dependencies & improper use of private deps.
was removed in fc59bd2 ("[3rd-party] update openthread and
ot-br-posix ([3rd-party] update openthread and ot-br-posix #5062)")