Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable new mkdocs-material features #2451

Merged
merged 1 commit into from
Apr 5, 2024
Merged

Conversation

jonaharagon
Copy link
Member

@jonaharagon jonaharagon commented Mar 28, 2024

Changes proposed in this PR:

LeYAi6UHW54Gzwmt

I'm not sure what I think about these. Give them a spin and let me know what you think.

  • I have disclosed any relevant conflicts of interest in my post.
  • I agree to grant Privacy Guides a perpetual, worldwide, non-exclusive, transferable, royalty-free, irrevocable license with the right to sublicense such rights through multiple tiers of sublicensees, to reproduce, modify, display, perform, relicense, and distribute my contribution as part of this project.
  • I am the sole author of this work.
  • I agree to the Community Code of Conduct.

@jonaharagon jonaharagon force-pushed the jonaharagon/new-mmi-features branch 2 times, most recently from c39444b to 20a397a Compare March 29, 2024 02:30
@jonaharagon jonaharagon force-pushed the jonaharagon/new-mmi-features branch from 20a397a to 3d66a95 Compare March 29, 2024 02:33
@jonaharagon jonaharagon force-pushed the jonaharagon/new-mmi-features branch from 3d66a95 to a4824b4 Compare March 29, 2024 02:37
@jonaharagon jonaharagon force-pushed the jonaharagon/new-mmi-features branch from a4824b4 to 66338de Compare March 29, 2024 02:39
@jonaharagon jonaharagon force-pushed the jonaharagon/new-mmi-features branch from 66338de to 447620d Compare March 29, 2024 02:42
@jonaharagon jonaharagon force-pushed the jonaharagon/new-mmi-features branch from 447620d to 522bb6f Compare March 29, 2024 02:57
@jonaharagon jonaharagon force-pushed the jonaharagon/new-mmi-features branch from 522bb6f to f37e532 Compare March 29, 2024 03:08
@jonaharagon jonaharagon force-pushed the jonaharagon/new-mmi-features branch from f37e532 to 3f62073 Compare March 29, 2024 03:09
@jonaharagon jonaharagon force-pushed the jonaharagon/new-mmi-features branch from 3f62073 to 03713d7 Compare March 29, 2024 03:12
@jonaharagon jonaharagon force-pushed the jonaharagon/new-mmi-features branch from 03713d7 to c2dee4a Compare March 29, 2024 03:25
@jonaharagon jonaharagon force-pushed the jonaharagon/new-mmi-features branch from c2dee4a to 5e2a76b Compare March 29, 2024 03:33
@jonaharagon jonaharagon force-pushed the jonaharagon/new-mmi-features branch from 5e2a76b to 31d0480 Compare March 29, 2024 03:45
@jonaharagon jonaharagon force-pushed the jonaharagon/new-mmi-features branch from 31d0480 to c7d024e Compare March 29, 2024 03:55
Copy link

github-actions bot commented Mar 29, 2024

Your preview is ready!

Name Link
🔨 Latest commit cf43545
😎 Preview https://cf43545f577d--glowing-salamander-8d7127.netlify.app/

@privacyguides privacyguides deleted a comment from netlify bot Mar 31, 2024
@jonaharagon jonaharagon force-pushed the jonaharagon/new-mmi-features branch from 8c3dabe to d2209e6 Compare March 31, 2024 14:40
@jonaharagon jonaharagon marked this pull request as ready for review March 31, 2024 14:47
@jonaharagon jonaharagon requested review from dngray and freddy-m March 31, 2024 14:47
@jonaharagon jonaharagon added the c:enhancements new features or other enhancements to the website itself label Apr 1, 2024
jonaharagon added a commit that referenced this pull request Apr 3, 2024
@jonaharagon jonaharagon force-pushed the jonaharagon/new-mmi-features branch from d2209e6 to 5f0605e Compare April 3, 2024 00:04
jonaharagon added a commit that referenced this pull request Apr 3, 2024
@jonaharagon jonaharagon force-pushed the jonaharagon/new-mmi-features branch from 5f0605e to 2614f11 Compare April 3, 2024 00:23
@jonaharagon jonaharagon mentioned this pull request Apr 3, 2024
4 tasks
@dngray
Copy link
Member

dngray commented Apr 3, 2024

Taking a look at this, I'm not sure I like the preview thing. Seems like it causes a lot of clutter say when mousing over buttons on the tools page.

dngray pushed a commit that referenced this pull request Apr 3, 2024
@dngray dngray force-pushed the jonaharagon/new-mmi-features branch from 2614f11 to d46358b Compare April 3, 2024 19:04
@jonaharagon jonaharagon marked this pull request as draft April 4, 2024 04:38
@jonaharagon jonaharagon marked this pull request as ready for review April 4, 2024 07:03
@redoomed1
Copy link
Member

redoomed1 commented Apr 4, 2024

After a cursory test of the instant link previews, I will note that there's one case where the preview is not that useful: when hovering over the General Criteria link that is on almost every tool recommendation page.

criteria-pop-up

I think that the previews for "whole page links" cover anything until the first permalink on the page, which explains the above behavior.

@jonaharagon
Copy link
Member Author

We can easily make a change to make this more meaningful with this feature in mind:

jarmMGa97Z6jGZxU

@jonaharagon
Copy link
Member Author

In the long term, instant link previews will be a critical component in replacing all the wikipedia links, links like those, and abbreviations in abbreviations.en.txt which aren't actually abbreviations across the website as well. For example (not in this PR, but in the future I'm looking to add an internal "privacy glossary" to provide this functionality):

image

Signed-off-by: Daniel Gray <dngray@privacyguides.org>
@dngray dngray force-pushed the jonaharagon/new-mmi-features branch from 8ae118f to cf43545 Compare April 5, 2024 10:44
@dngray
Copy link
Member

dngray commented Apr 5, 2024

replacing all the wikipedia links, links like those, and abbreviations in abbreviations.en.txt which aren't actually abbreviations across the website as well. For example (not in this PR, but in the future I'm looking to add an internal "privacy glossary" to provide this functionality):

Sounds like a good idea, I checked a few pages of this now and everything seems to be working great.

@dngray dngray merged commit cf43545 into main Apr 5, 2024
20 checks passed
@dngray dngray deleted the jonaharagon/new-mmi-features branch April 5, 2024 10:46
@privacyguides-bot
Copy link
Collaborator

This pull request has been mentioned on Privacy Guides. There might be relevant details there:

https://discuss.privacyguides.net/t/2024-04-08/17760/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:enhancements new features or other enhancements to the website itself
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants