-
-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable new mkdocs-material features #2451
Conversation
c39444b
to
20a397a
Compare
20a397a
to
3d66a95
Compare
3d66a95
to
a4824b4
Compare
a4824b4
to
66338de
Compare
66338de
to
447620d
Compare
447620d
to
522bb6f
Compare
522bb6f
to
f37e532
Compare
f37e532
to
3f62073
Compare
3f62073
to
03713d7
Compare
03713d7
to
c2dee4a
Compare
c2dee4a
to
5e2a76b
Compare
5e2a76b
to
31d0480
Compare
31d0480
to
c7d024e
Compare
✅ Your preview is ready!
|
c7d024e
to
526a6aa
Compare
8c3dabe
to
d2209e6
Compare
d2209e6
to
5f0605e
Compare
5f0605e
to
2614f11
Compare
Taking a look at this, I'm not sure I like the preview thing. Seems like it causes a lot of clutter say when mousing over buttons on the tools page. |
2614f11
to
d46358b
Compare
After a cursory test of the instant link previews, I will note that there's one case where the preview is not that useful: when hovering over the General Criteria link that is on almost every tool recommendation page. I think that the previews for "whole page links" cover anything until the first permalink on the page, which explains the above behavior. |
In the long term, instant link previews will be a critical component in replacing all the wikipedia links, links like those, and abbreviations in |
Signed-off-by: Daniel Gray <dngray@privacyguides.org>
8ae118f
to
cf43545
Compare
Sounds like a good idea, I checked a few pages of this now and everything seems to be working great. |
This pull request has been mentioned on Privacy Guides. There might be relevant details there: |
Changes proposed in this PR:
I'm not sure what I think about these. Give them a spin and let me know what you think.