-
-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update docs links for various tools and make numerous other changes #2489
Conversation
✅ Your preview is ready!
|
b9a7ba4
to
289a762
Compare
You should rebase your commits in a PR instead of merging main into your branch btw https://www.privacyguides.org/en/meta/git-recommendations/#rebase-from-main-before-submitting-a-pr or, if you don't use Git locally, don't bother and let us handle it :) |
Understood, sorry about that. I have been using GitHub.com's web editor directly, and am still learning. Thanks for the feedback! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regarding https://github.com/privacyguides/privacyguides.org/pull/2489/files#r1554333828 I've decided that I do want proper nouns like Mailbox.org to be capitalized :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: Jonah Aragon <jonah@triplebit.net> Signed-off-by: Daniel Gray <dngray@privacyguides.org>
This pull request has been mentioned on Privacy Guides. There might be relevant details there: https://discuss.privacyguides.net/t/2024-04-08-a1b01b8b/17776/1 |
Changes proposed in this PR:
mailbox.org
that are not at the beginning of a sentence to match how the service refers to itself in its documentationthunderbird-user.js
description from "surface area" to "attack surface"(CLI)
next to the gopass heading and set its recommendation card to a third-level heading to match formatting in other pages such as the Email Clients page