Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace external links with internal ones where appropriate and fix internal links #2583

Merged
merged 1 commit into from
May 31, 2024
Merged

Replace external links with internal ones where appropriate and fix internal links #2583

merged 1 commit into from
May 31, 2024

Conversation

redoomed1
Copy link
Member

@redoomed1 redoomed1 commented May 26, 2024 •
edited
Loading

Changes proposed in this PR:

  • Replace several external links for tools already listed on the site with internal links if an embedded link points to a website already listed on the relevant recommendation card
  • On the DNS Overview page, expand on introduction for "What is Encrypted DNS?" for more useful instant previews
  • On the Multi-Factor Authentication page, fix internal link to VeraCrypt card
  • tools.md
    • Add Redlib and ProxiTok entries as it seems that the PRs that added both did not do so
    • Fix link to OS Full Disk Encryption section under the teal "Operating System Disk Encryption" toggle
  • I agree to the terms listed below:
    Contribution terms (click to expand) 1) I am the sole author of this work. 2) I agree to grant Privacy Guides a perpetual, worldwide, non-exclusive, transferable, royalty-free, irrevocable license with the right to sublicense such rights through multiple tiers of sublicensees, to reproduce, modify, display, perform, relicense, and distribute my contribution as part of this project. 3) I have disclosed any relevant conflicts of interest in my post. 4) I agree to the Community Code of Conduct.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 26, 2024 •
edited
Loading

✅ Your preview is ready!

Name Link
🔨 Latest commit 0bc8336
😎 Preview https://2583--glowing-salamander-8d7127.netlify.app/

@dngray dngray added the c:enhancements new features or other enhancements to the website itself label May 26, 2024
@redoomed1 redoomed1 marked this pull request as ready for review May 26, 2024 22:41
@redoomed1 redoomed1 changed the title Rewrite and add introductions for useful hover text Add introductions to MFA Tools page for useful instant previews May 27, 2024
@redoomed1 redoomed1 changed the title Add introductions to MFA Tools page for useful instant previews Replace external links with internal ones where appropriate and fix internal links May 30, 2024
@dngray
Copy link
Member

dngray commented May 31, 2024

This one looks good. Are you ready for merging?

@redoomed1
Copy link
Member Author

Yes @dngray

@redoomed1 @jonaharagon @dngray
fix: replace external links with internal (#2583)
0bc8336 
Co-authored-by: Jonah Aragon <jonah@triplebit.net>
Signed-off-by: Daniel Gray <dngray@privacyguides.org>
@dngray dngray merged commit 0bc8336 into privacyguides:main May 31, 2024
11 checks passed
@redoomed1 redoomed1 deleted the hover-text-foray branch May 31, 2024 16:11
@privacyguides-bot
Copy link
Collaborator

This pull request has been mentioned on Privacy Guides. There might be relevant details there:

https://discuss.privacyguides.net/t/2024-06-01/18648/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonaharagon jonaharagon jonaharagon left review comments

Assignees
No one assigned
Labels
c:enhancements new features or other enhancements to the website itself
Projects
PR Review Status
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@redoomed1 @dngray @privacyguides-bot @jonaharagon