Add auto-detect when no config file is given #52
Conversation
|
Blocked by #54 |
|
@preslavmihaylov Made some changes. Could you please re-review it? |
| } | ||
| if err := ioutil.WriteFile(gitDir+"/config", []byte(gitConfig), 0644); err != nil { | ||
| t.Errorf("%s", err) | ||
| } |
There was a problem hiding this comment.
This is a nice way to handle the issue.
Could you extract it in the scenariobuilder as e.g. WithGitConfig(the parameters added in a git config) so that it can be reused across several tests?
testing/todocheck_test.go
Outdated
| // make sure it's there beforehand. | ||
| gitDir := "./scenarios/auto_detect_config/.git" | ||
| gitConfig := `[remote "origin"] | ||
| url = git@github.com:test_username/test_repo.git |
There was a problem hiding this comment.
Could you also add a test for detecting an origin specified without the .git extension? E.g.
url = https://github.com/preslavmihaylov/todocheck
There was a problem hiding this comment.
This is why I requested the change about WithGitConfig
There was a problem hiding this comment.
Full configuration example:
[core]
repositoryformatversion = 0
filemode = true
bare = false
logallrefupdates = true
ignorecase = true
precomposeunicode = true
[remote "origin"]
url = https://github.com/preslavmihaylov/todocheck
fetch = +refs/heads/*:refs/remotes/origin/*
[branch "master"]
remote = origin
merge = refs/heads/master
rebase = true
Additional changes are requested
There was a problem hiding this comment.
There is still one more test case I'd like us to set in place in order to make sure we cover deriving the origin from both ssh-based URIs and http-based ones.
Additionally, the request for documenting the new behavior in the README or creating a new issue for it still stands.
Signed-off-by: Mehdy Khoshnoody <mehdy.khoshnoody@gmail.com>
Signed-off-by: Mehdy Khoshnoody <mehdy.khoshnoody@gmail.com>
|
Created a new issue to add docs about this feature. #58 |
Closes #50