Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strip the trailing ".git" when auto-detecting config from an SSH-cloned git repo #59

Closed
preslavmihaylov opened this issue Sep 9, 2020 · 3 comments · Fixed by #61
Closed
Labels
bug Something isn't working

Comments

@preslavmihaylov
Copy link
Owner

When a repo is cloned using ssh, it has the .git suffix in its remote url in .git/config.

This is correctly detected from todocheck as a github configuration. However, all subsequent calls for issues fail as the github API doesn't consider github.com/user/repo.git the same as github.com/user/repo.

See example:
image

In the image above, I have a private repo setup, called todocheck-mock with issues 1 (closed) and 2 (open).
todocheck incorrectly detects both issues as non-existent as the API calls are not targeted towards the right repo.

@preslavmihaylov preslavmihaylov added the bug Something isn't working label Sep 9, 2020
@preslavmihaylov
Copy link
Owner Author

Follow-up from #50 and #52

@mehdy cc

@preslavmihaylov
Copy link
Owner Author

Double-checked this again by instrumenting the app \w a logline showing the interpreted origin:
image

@mehdy
Copy link
Collaborator

mehdy commented Sep 10, 2020

This is odd. 🤨
I'll look into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants