Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue tracker auto detector's regex #61

Merged
merged 1 commit into from
Sep 13, 2020
Merged

Fix issue tracker auto detector's regex #61

merged 1 commit into from
Sep 13, 2020

Conversation

mehdy
Copy link
Collaborator

@mehdy mehdy commented Sep 11, 2020

The new regex now detects origin and host better and totally ignores the existence of the .git part.

Fixes: #59

@mehdy
Fix issue tracker auto detector's regex
34df8e7 
Signed-off-by: Mehdy Khoshnoody <mehdy.khoshnoody@gmail.com>
@preslavmihaylov
Copy link
Owner

Thanks, I've tested your branch locally & it works as expected now!

I've also discovered another issue (#62) in the process.

preslavmihaylov
preslavmihaylov approved these changes Sep 13, 2020
View reviewed changes
Copy link
Owner

@preslavmihaylov preslavmihaylov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested the branch locally & it now works as expected.

@preslavmihaylov preslavmihaylov merged commit 22a5fe9 into preslavmihaylov:master Sep 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@preslavmihaylov preslavmihaylov preslavmihaylov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Strip the trailing ".git" when auto-detecting config from an SSH-cloned git repo
2 participants
@mehdy @preslavmihaylov