Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

setup CI for running build + tests on PR and push #54

Merged
merged 8 commits into from
Sep 6, 2020
Merged

setup CI for running build + tests on PR and push #54

merged 8 commits into from
Sep 6, 2020

Conversation

preslavmihaylov
Copy link
Owner

@preslavmihaylov preslavmihaylov commented Sep 4, 2020 •
edited
Loading

Closes #51

@preslavmihaylov
Copy link
Owner Author

@mehdy do you mind making a review?

This was referenced Sep 4, 2020
Merged
Merged
@mehdy
Copy link
Collaborator

mehdy commented Sep 4, 2020

@mehdy do you mind making a review?

Sure! Will do.

@preslavmihaylov preslavmihaylov assigned mehdy and unassigned mehdy Sep 4, 2020
mehdy
mehdy reviewed Sep 5, 2020
View reviewed changes
Copy link
Collaborator

@mehdy mehdy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.
I left some notes and I hope it helps.

.github/workflows/master.yaml Outdated Show resolved Hide resolved
.github/workflows/master.yaml Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
@preslavmihaylov
Copy link
Owner Author

Thanks a lot!

I've fixed the issues you mentioned. Let me know if it's okay now.

mehdy
mehdy approved these changes Sep 6, 2020
View reviewed changes
Copy link
Collaborator

@mehdy mehdy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mehdy
Copy link
Collaborator

mehdy commented Sep 6, 2020

Should I go for the merge? 😃

@preslavmihaylov
Copy link
Owner Author

Go ahead. :)

@mehdy mehdy merged commit 5bf8e69 into master Sep 6, 2020
@preslavmihaylov preslavmihaylov deleted the build-tests-ci branch September 7, 2020 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mehdy mehdy mehdy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add CI to run the tests
2 participants
@preslavmihaylov @mehdy